Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mm/page_alloc: check the correct buddy if it is a starting block

find_large_buddy() search buddy based on start_pfn, which maybe different
from page's pfn, e.g. when page is not pageblock aligned, because
prep_move_freepages_block() always align start_pfn to pageblock.

This means when we found a starting block at start_pfn, it may check on
the wrong page theoretically. And not split the free page as it is
supposed to, causing a freelist migratetype mismatch.

The good news is the page passed to __move_freepages_block_isolate() has
only two possible cases:

* page is pageblock aligned
* page is __first_valid_page() of this block

So it is safe for the first case, and it won't get a buddy larger than
pageblock for the second case.

To fix the issue, check the returned pfn of find_large_buddy() to decide
whether to split the free page:

1. if it is not a PageBuddy pfn, no split;
2. if it is a PageBuddy pfn but order <= pageblock_order, no split;
3. if it is a PageBuddy pfn with order > pageblock_order, start_pfn is
either in the starting block or tail block, split the PageBuddy at
pageblock_order level.

Link: https://lkml.kernel.org/r/20250905140358.28849-1-richard.weiyang@gmail.com
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
Reviewed-by: Zi Yan <ziy@nvidia.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: David Hildenbrand <david@redhat.com>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

Wei Yang and committed by
Andrew Morton
4805ef37 5ce1dbfd

+8 -17
+8 -17
mm/page_alloc.c
··· 2090 2090 static bool __move_freepages_block_isolate(struct zone *zone, 2091 2091 struct page *page, bool isolate) 2092 2092 { 2093 - unsigned long start_pfn, pfn; 2093 + unsigned long start_pfn, buddy_pfn; 2094 2094 int from_mt; 2095 2095 int to_mt; 2096 + struct page *buddy; 2096 2097 2097 2098 if (isolate == get_pageblock_isolate(page)) { 2098 2099 VM_WARN_ONCE(1, "%s a pageblock that is already in that state", ··· 2108 2107 if (pageblock_order == MAX_PAGE_ORDER) 2109 2108 goto move; 2110 2109 2111 - /* We're a tail block in a larger buddy */ 2112 - pfn = find_large_buddy(start_pfn); 2113 - if (pfn != start_pfn) { 2114 - struct page *buddy = pfn_to_page(pfn); 2110 + buddy_pfn = find_large_buddy(start_pfn); 2111 + buddy = pfn_to_page(buddy_pfn); 2112 + /* We're a part of a larger buddy */ 2113 + if (PageBuddy(buddy) && buddy_order(buddy) > pageblock_order) { 2115 2114 int order = buddy_order(buddy); 2116 2115 2117 2116 del_page_from_free_list(buddy, zone, order, 2118 - get_pfnblock_migratetype(buddy, pfn)); 2117 + get_pfnblock_migratetype(buddy, buddy_pfn)); 2119 2118 toggle_pageblock_isolate(page, isolate); 2120 - split_large_buddy(zone, buddy, pfn, order, FPI_NONE); 2119 + split_large_buddy(zone, buddy, buddy_pfn, order, FPI_NONE); 2121 2120 return true; 2122 2121 } 2123 2122 2124 - /* We're the starting block of a larger buddy */ 2125 - if (PageBuddy(page) && buddy_order(page) > pageblock_order) { 2126 - int order = buddy_order(page); 2127 - 2128 - del_page_from_free_list(page, zone, order, 2129 - get_pfnblock_migratetype(page, pfn)); 2130 - toggle_pageblock_isolate(page, isolate); 2131 - split_large_buddy(zone, page, pfn, order, FPI_NONE); 2132 - return true; 2133 - } 2134 2123 move: 2135 2124 /* Use MIGRATETYPE_MASK to get non-isolate migratetype */ 2136 2125 if (isolate) {