tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

bonding: only set speed/duplex to unknown, if getting speed failed

bond_update_speed_duplex() first set speed/duplex to unknown and
then asks slave driver for current speed/duplex. Since getting
speed/duplex might take longer there is a race, where this false state
is visible by /proc/net/bonding. With commit 691b2bf14946 ("bonding:
update port speed when getting bond speed") this race gets more visible,
if user space is calling ethtool on a regular base.

Fix this by only setting speed/duplex to unknown, if link speed is
really unknown/unusable.

Fixes: 98f41f694f46 ("bonding:update speed/duplex for NETDEV_CHANGE")
Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
Acked-by: Jay Vosburgh <jv@jvosburgh.net>
Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
Link: https://patch.msgid.link/20260203141153.51581-1-tbogendoerfer@suse.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Thomas Bogendoerfer and committed by
Jakub Kicinski 48dec8d8 2d2d5743

+9 -6
+9 -6
drivers/net/bonding/bond_main.c
··· 791 791 struct ethtool_link_ksettings ecmd; 792 792 int res; 793 793 794 - slave->speed = SPEED_UNKNOWN; 795 - slave->duplex = DUPLEX_UNKNOWN; 796 - 797 794 res = __ethtool_get_link_ksettings(slave_dev, &ecmd); 798 795 if (res < 0) 799 - return 1; 796 + goto speed_duplex_unknown; 800 797 if (ecmd.base.speed == 0 || ecmd.base.speed == ((__u32)-1)) 801 - return 1; 798 + goto speed_duplex_unknown; 802 799 switch (ecmd.base.duplex) { 803 800 case DUPLEX_FULL: 804 801 case DUPLEX_HALF: 805 802 break; 806 803 default: 807 - return 1; 804 + goto speed_duplex_unknown; 808 805 } 809 806 810 807 slave->speed = ecmd.base.speed; 811 808 slave->duplex = ecmd.base.duplex; 812 809 813 810 return 0; 811 + 812 + speed_duplex_unknown: 813 + slave->speed = SPEED_UNKNOWN; 814 + slave->duplex = DUPLEX_UNKNOWN; 815 + 816 + return 1; 814 817 } 815 818 816 819 const char *bond_slave_link_status(s8 link)