tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

phy: make PHY_COMMON_PROPS Kconfig symbol conditionally user-selectable

Geert reports that enabling CONFIG_KUNIT_ALL_TESTS shouldn't enable
features that aren't enabled without it. That isn't what "*all* tests"
means, but as the prompt puts it, "All KUnit tests with satisfied
dependencies".

The impact is that enabling CONFIG_KUNIT_ALL_TESTS brings features which
cannot be disabled as built-in into the kernel.

Keep the pattern where consumer drivers have to "select PHY_COMMON_PROPS",
but if KUNIT_ALL_TESTS is enabled, also make PHY_COMMON_PROPS user
selectable, so it can be turned off.

Modify PHY_COMMON_PROPS_TEST to depend on PHY_COMMON_PROPS rather than
select it.

Fixes: e7556b59ba65 ("phy: add phy_get_rx_polarity() and phy_get_tx_polarity()")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Closes: https://lore.kernel.org/linux-phy/CAMuHMdUBaoYKNj52gn8DQeZFZ42Cvm6xT6fvo0-_twNv1k3Jhg@mail.gmail.com/
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://patch.msgid.link/20260226153315.3530378-1-vladimir.oltean@nxp.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Vladimir Oltean and committed by
Vinod Koul 48fafffc 6de23f81

+2 -3
+2 -3
drivers/phy/Kconfig
··· 6 6 menu "PHY Subsystem" 7 7 8 8 config PHY_COMMON_PROPS 9 - bool 9 + bool "PHY common properties" if KUNIT_ALL_TESTS 10 10 help 11 11 This parses properties common between generic PHYs and Ethernet PHYs. 12 12 ··· 16 16 17 17 config PHY_COMMON_PROPS_TEST 18 18 tristate "KUnit tests for PHY common props" if !KUNIT_ALL_TESTS 19 - select PHY_COMMON_PROPS 20 - depends on KUNIT 19 + depends on KUNIT && PHY_COMMON_PROPS 21 20 default KUNIT_ALL_TESTS 22 21 help 23 22 This builds KUnit tests for the PHY common property API.