tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

phy: ti: gmii-sel: fix regmap leak on probe failure

The mmio regmap that may be allocated during probe is never freed.

Switch to using the device managed allocator so that the regmap is
released on probe failures (e.g. probe deferral) and on driver unbind.

Fixes: 5ab90f40121a ("phy: ti: gmii-sel: Do not use syscon helper to build regmap")
Cc: stable@vger.kernel.org # 6.14
Cc: Andrew Davis <afd@ti.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Andrew Davis <afd@ti.com>
Link: https://patch.msgid.link/20251127134834.2030-1-johan@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Johan Hovold and committed by
Vinod Koul 4914d67d d543d3eb

+1 -1
+1 -1
drivers/phy/ti/phy-gmii-sel.c
··· 512 512 return dev_err_probe(dev, PTR_ERR(base), 513 513 "failed to get base memory resource\n"); 514 514 515 - priv->regmap = regmap_init_mmio(dev, base, &phy_gmii_sel_regmap_cfg); 515 + priv->regmap = devm_regmap_init_mmio(dev, base, &phy_gmii_sel_regmap_cfg); 516 516 if (IS_ERR(priv->regmap)) 517 517 return dev_err_probe(dev, PTR_ERR(priv->regmap), 518 518 "Failed to get syscon\n");