tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Don't warn about order-1 allocations with __GFP_NOFAIL

Traditionally, we never failed small orders (even regardless of any
__GFP_NOFAIL flags), and slab will allocate order-1 allocations even for
small allocations that could fit in a single page (in order to avoid
excessive fragmentation).

Maybe we should remove this warning entirely, but before making that
judgement, at least limit it to bigger allocations.

Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Linus Torvalds 4923abf9 c82e6d45

+2 -2
+2 -2
mm/page_alloc.c
··· 1153 1153 * properly detect and handle allocation failures. 1154 1154 * 1155 1155 * We most definitely don't want callers attempting to 1156 - * allocate greater than single-page units with 1156 + * allocate greater than order-1 page units with 1157 1157 * __GFP_NOFAIL. 1158 1158 */ 1159 - WARN_ON_ONCE(order > 0); 1159 + WARN_ON_ONCE(order > 1); 1160 1160 } 1161 1161 spin_lock_irqsave(&zone->lock, flags); 1162 1162 page = __rmqueue(zone, order, migratetype);