tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

phy: rockchip: phy-rockchip-inno-dsidphy: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20230307115900.2293120-21-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Uwe Kleine-König and committed by
Vinod Koul 497a3832 b41f07b2

+2 -4
+2 -4
drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
··· 755 755 return 0; 756 756 } 757 757 758 - static int inno_dsidphy_remove(struct platform_device *pdev) 758 + static void inno_dsidphy_remove(struct platform_device *pdev) 759 759 { 760 760 struct inno_dsidphy *inno = platform_get_drvdata(pdev); 761 761 762 762 pm_runtime_disable(inno->dev); 763 - 764 - return 0; 765 763 } 766 764 767 765 static const struct of_device_id inno_dsidphy_of_match[] = { ··· 786 788 .of_match_table = of_match_ptr(inno_dsidphy_of_match), 787 789 }, 788 790 .probe = inno_dsidphy_probe, 789 - .remove = inno_dsidphy_remove, 791 + .remove_new = inno_dsidphy_remove, 790 792 }; 791 793 module_platform_driver(inno_dsidphy_driver); 792 794