tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/panel: samsung-atna33xc20: Don't call unprepare+disable at shutdown/remove

It's the responsibility of a correctly written DRM modeset driver to
call drm_atomic_helper_shutdown() at shutdown time and that should be
disabling / unpreparing the panel if needed. Panel drivers shouldn't
be calling these functions themselves.

A recent effort was made to fix as many DRM modeset drivers as
possible [1] [2] [3] and most drivers are fixed now.

A grep through mainline for compatible strings used by this driver
indicates that it is used by Qualcomm boards. The Qualcomm driver
appears to be correctly calling drm_atomic_helper_shutdown() so we can
remove the calls.

[1] https://lore.kernel.org/r/20230901234015.566018-1-dianders@chromium.org
[2] https://lore.kernel.org/r/20230901234202.566951-1-dianders@chromium.org
[3] https://lore.kernel.org/r/20230921192749.1542462-1-dianders@chromium.org

Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240503143327.RFT.v2.25.Iaeacccf98e6cb729b8fc3a782725769cd66812ad@changeid

Douglas Anderson 49869668 5a847750

-12
-12
drivers/gpu/drm/panel/panel-samsung-atna33xc20.c
··· 327 327 struct atana33xc20_panel *panel = dev_get_drvdata(dev); 328 328 329 329 drm_panel_remove(&panel->base); 330 - drm_panel_disable(&panel->base); 331 - drm_panel_unprepare(&panel->base); 332 330 333 331 drm_edid_free(panel->drm_edid); 334 - } 335 - 336 - static void atana33xc20_shutdown(struct dp_aux_ep_device *aux_ep) 337 - { 338 - struct device *dev = &aux_ep->dev; 339 - struct atana33xc20_panel *panel = dev_get_drvdata(dev); 340 - 341 - drm_panel_disable(&panel->base); 342 - drm_panel_unprepare(&panel->base); 343 332 } 344 333 345 334 static const struct of_device_id atana33xc20_dt_match[] = { ··· 351 362 }, 352 363 .probe = atana33xc20_probe, 353 364 .remove = atana33xc20_remove, 354 - .shutdown = atana33xc20_shutdown, 355 365 }; 356 366 357 367 static int __init atana33xc20_init(void)