tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mei: vsc: Do not re-enable interrupt from vsc_tp_reset()

The only 2 callers of vsc_tp_reset() are:

1. mei_vsc_hw_reset(), which immediataly calls vsc_tp_intr_disable()
afterwards.

2. vsc_tp_shutdown() which immediately calls free_irq() afterwards.

So neither actually wants the interrupt to be enabled after resetting
the chip and having the interrupt enabled for a short time afer
the reset is undesirable.

Drop the enable_irq() call from vsc_tp_reset(), so that the interrupt
is left disabled after vsc_tp_reset().

Link: https://github.com/intel/ivsc-driver/issues/51
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20241106220102.40549-1-hdegoede@redhat.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Hans de Goede and committed by
Greg Kroah-Hartman 49988a79 9aa45ca7

-4
-2
drivers/misc/mei/platform-vsc.c
··· 256 256 257 257 vsc_tp_reset(hw->tp); 258 258 259 - vsc_tp_intr_disable(hw->tp); 260 - 261 259 return vsc_tp_init(hw->tp, mei_dev->dev); 262 260 } 263 261
-2
drivers/misc/mei/vsc-tp.c
··· 364 364 gpiod_set_value_cansleep(tp->wakeupfw, 1); 365 365 366 366 atomic_set(&tp->assert_cnt, 0); 367 - 368 - enable_irq(tp->spi->irq); 369 367 } 370 368 EXPORT_SYMBOL_NS_GPL(vsc_tp_reset, VSC_TP); 371 369