tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/amd/display: Undo accidental fix revert in amdgpu_dm_ism.c

[Why]

Pausing DPM power profiles during static screen caused a bunch of
audio/performance/clock issues that were addressed in this fix:
'commit 1412482b7143 ("Revert "drm/amd/display: pause the workload setting in dm"")'

This logic in function amdgpu_dm_crtc_vblank_control_worker() was moved
to amdgpu_dm_ism.c, but the fix was lost in the process.

[How]

Reapply the fix to amdgpu_dm_ism.c

Fixes: 754003486c3c ("drm/amd/display: Add Idle state manager(ISM)")
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
Signed-off-by: Leo Li <sunpeng.li@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit bc621e91d6fc004cfae9148c5a91acad19ada3e4)

authored by

Leo Li and committed by
Alex Deucher 49ed6f45 dd88d42d

-10
-10
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_ism.c
··· 270 270 struct amdgpu_crtc *acrtc = ism_to_amdgpu_crtc(ism); 271 271 struct amdgpu_device *adev = drm_to_adev(acrtc->base.dev); 272 272 struct amdgpu_display_manager *dm = &adev->dm; 273 - int r; 274 273 275 274 trace_amdgpu_dm_ism_commit(dm->active_vblank_irq_count, 276 275 vblank_enabled, ··· 322 323 */ 323 324 if (!vblank_enabled && dm->active_vblank_irq_count == 0) { 324 325 dc_post_update_surfaces_to_stream(dm->dc); 325 - 326 - r = amdgpu_dpm_pause_power_profile(adev, true); 327 - if (r) 328 - dev_warn(adev->dev, "failed to set default power profile mode\n"); 329 - 330 326 dc_allow_idle_optimizations(dm->dc, true); 331 - 332 - r = amdgpu_dpm_pause_power_profile(adev, false); 333 - if (r) 334 - dev_warn(adev->dev, "failed to restore the power profile mode\n"); 335 327 } 336 328 } 337 329