tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ASoC: codecs: rt56*: Remove IRQF_ONESHOT

Passing IRQF_ONESHOT ensures that the interrupt source is masked until
the secondary (threaded) handler is done. If only a primary handler is
used then the flag makes no sense because the interrupt can not fire
(again) while its handler is running.
The flag also disallows force-threading of the primary handler and the
irq-core will warn about this.

Remove IRQF_ONESHOT from irqflags.

Cc: Oder Chiou <oder_chiou@realtek.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: linux-sound@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: https://patch.msgid.link/20260123113708.416727-13-bigeasy@linutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Sebastian Andrzej Siewior and committed by
Mark Brown 4a393958 506e0825

+5 -5
+2 -2
sound/soc/codecs/rt5640.c
··· 2564 2564 rt5640->use_platform_clock = jack_data->use_platform_clock; 2565 2565 2566 2566 ret = request_irq(rt5640->irq, rt5640_irq, 2567 - IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT, 2567 + IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING, 2568 2568 "rt5640", rt5640); 2569 2569 if (ret) { 2570 2570 dev_warn(component->dev, "Failed to request IRQ %d: %d\n", rt5640->irq, ret); ··· 2618 2618 rt5640->jack = jack; 2619 2619 2620 2620 ret = request_irq(rt5640->irq, rt5640_irq, 2621 - IRQF_TRIGGER_RISING | IRQF_ONESHOT, "rt5640", rt5640); 2621 + IRQF_TRIGGER_RISING, "rt5640", rt5640); 2622 2622 if (ret) { 2623 2623 dev_warn(component->dev, "Failed to request IRQ %d: %d\n", rt5640->irq, ret); 2624 2624 rt5640->jack = NULL;
+1 -1
sound/soc/codecs/rt5651.c
··· 2262 2262 2263 2263 ret = devm_request_irq(&i2c->dev, rt5651->irq, rt5651_irq, 2264 2264 IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING 2265 - | IRQF_ONESHOT | IRQF_NO_AUTOEN, "rt5651", rt5651); 2265 + | IRQF_NO_AUTOEN, "rt5651", rt5651); 2266 2266 if (ret) { 2267 2267 dev_warn(&i2c->dev, "Failed to request IRQ %d: %d\n", 2268 2268 rt5651->irq, ret);
+2 -2
sound/soc/codecs/rt5663.c
··· 3689 3689 3690 3690 if (i2c->irq) { 3691 3691 ret = request_irq(i2c->irq, rt5663_irq, 3692 - IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING 3693 - | IRQF_ONESHOT, "rt5663", rt5663); 3692 + IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING, 3693 + "rt5663", rt5663); 3694 3694 if (ret) { 3695 3695 dev_err(&i2c->dev, "%s Failed to request IRQ: %d\n", 3696 3696 __func__, ret);