Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mm/damon/core: introduce nr_snapshots damos stat

Patch series "mm/damon: introduce {,max_}nr_snapshots and tracepoint for
damos stats".

Introduce three changes for improving DAMOS stat's provided information,
deterministic control, and reading usability.

DAMOS provides stats that are important for understanding its behavior.
It lacks information about how many DAMON-generated monitoring output
snapshots it has worked on. Add a new stat, nr_snapshots, to show the
information.

Users can control DAMOS schemes in multiple ways. Using the online
parameters commit feature, they can install and uninstall DAMOS schemes
whenever they want while keeping DAMON runs. DAMOS quotas and watermarks
can be used for manually or automatically turning on/off or adjusting the
aggressiveness of the scheme. DAMOS filters can be used for applying the
scheme to specific memory entities based on their types and locations.
Some users want their DAMOS scheme to be applied to only specific number
of DAMON snapshots, for more deterministic control. One example use case
is tracepoint based snapshot reading. Add a new knob, max_nr_snapshots,
to support this. If the nr_snapshots parameter becomes same to or greater
than the value of this parameter, the scheme is deactivated.

Users can read DAMOS stats via DAMON's sysfs interface. For deep level
investigations on environments having advanced tools like perf and
bpftrace, exposing the stats via a tracepoint can be useful. Implement a
new tracepoint, namely damon:damos_stat_after_apply_interval.

First five patches (patches 1-5) of this series implement the new stat,
nr_snapshots, on the core layer (patch 1), expose on DAMON sysfs user
interface (patch 2), and update documents (patches 3-5).

Following six patches (patches 6-11) are for the new stat based DAMOS
deactivation (max_nr_snapshots). The first one (patch 6) of this group
updates a kernel-doc comment before making further changes. Then an
implementation of it on the core layer (patch 7), an introduction of a new
DAMON sysfs interface file for users of the feature (patch 8), and three
updates of the documents (patches 9-11) follow.

The final one (patch 12) introduces the new tracepoint that exposes the
DAMOS stat values for each scheme apply interval.


This patch (of 12):

DAMON generates monitoring results snapshots for every sampling interval.
DAMOS applies given schemes on the regions of the snapshots, for every
apply interval of the scheme.

DAMOS stat informs a given scheme has tried to how many memory entities
and applied, in the region and byte level. In some use cases including
user-space oriented tuning and investigations, it is useful to know that
in the DAMON-snapshot level. Introduce a new stat, namely nr_snapshots
for DAMON core API callers.

[sj@kernel.org: fix wrong list_is_last() call in damons_is_last_region()]
Link: https://lkml.kernel.org/r/20260114152049.99727-1-sj@kernel.org
Link: https://lkml.kernel.org/r/20251216080128.42991-1-sj@kernel.org
Link: https://lkml.kernel.org/r/20251216080128.42991-2-sj@kernel.org
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Liam Howlett <liam.howlett@oracle.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

SeongJae Park and committed by
Andrew Morton
4a6ceb7c 8b8017d7

+13 -3
+3
include/linux/damon.h
··· 330 330 * @sz_ops_filter_passed: 331 331 * Total bytes that passed ops layer-handled DAMOS filters. 332 332 * @qt_exceeds: Total number of times the quota of the scheme has exceeded. 333 + * @nr_snapshots: 334 + * Total number of DAMON snapshots that the scheme has tried. 333 335 * 334 336 * "Tried an action to a region" in this context means the DAMOS core logic 335 337 * determined the region as eligible to apply the action. The access pattern ··· 357 355 unsigned long sz_applied; 358 356 unsigned long sz_ops_filter_passed; 359 357 unsigned long qt_exceeds; 358 + unsigned long nr_snapshots; 360 359 }; 361 360 362 361 /**
+10 -3
mm/damon/core.c
··· 157 157 damon_free_region(r); 158 158 } 159 159 160 + static bool damon_is_last_region(struct damon_region *r, 161 + struct damon_target *t) 162 + { 163 + return list_is_last(&r->list, &t->regions_list); 164 + } 165 + 160 166 /* 161 167 * Check whether a region is intersecting an address range 162 168 * ··· 1984 1978 if (damos_skip_charged_region(t, &r, s, c->min_sz_region)) 1985 1979 continue; 1986 1980 1987 - if (!damos_valid_target(c, t, r, s)) 1988 - continue; 1981 + if (damos_valid_target(c, t, r, s)) 1982 + damos_apply_scheme(c, t, r, s); 1989 1983 1990 - damos_apply_scheme(c, t, r, s); 1984 + if (damon_is_last_region(r, t)) 1985 + s->stat.nr_snapshots++; 1991 1986 } 1992 1987 } 1993 1988