tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: usb: sr9700: rename register write commands for clarity

SR_WR_REG and SR_WR_REGS may be confused at a cursory glance. Rename
them to be more easily differentiated to prevent this.

Suggested-by: Andrew Lunn <andrew+netdev@lunn.ch>
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Peter Korsgaard <peter@korsgaard.com>
Link: https://patch.msgid.link/20260123080409.64165-1-enelsonmoore@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Ethan Nelson-Moore and committed by
Jakub Kicinski 4a7bbaa6 c2e99887

+6 -6
+4 -4
drivers/net/usb/sr9700.c
··· 37 37 { 38 38 int err; 39 39 40 - err = usbnet_write_cmd(dev, SR_WR_REGS, SR_REQ_WR_REG, 0, reg, data, 40 + err = usbnet_write_cmd(dev, SR_WR_MULTIPLE_REGS, SR_REQ_WR_REG, 0, reg, data, 41 41 length); 42 42 if ((err >= 0) && (err < length)) 43 43 err = -EINVAL; ··· 51 51 52 52 static int sr_write_reg(struct usbnet *dev, u8 reg, u8 value) 53 53 { 54 - return usbnet_write_cmd(dev, SR_WR_REG, SR_REQ_WR_REG, 54 + return usbnet_write_cmd(dev, SR_WR_SINGLE_REG, SR_REQ_WR_REG, 55 55 value, reg, NULL, 0); 56 56 } 57 57 58 58 static void sr_write_async(struct usbnet *dev, u8 reg, u16 length, 59 59 const void *data) 60 60 { 61 - usbnet_write_cmd_async(dev, SR_WR_REGS, SR_REQ_WR_REG, 61 + usbnet_write_cmd_async(dev, SR_WR_MULTIPLE_REGS, SR_REQ_WR_REG, 62 62 0, reg, data, length); 63 63 } 64 64 65 65 static void sr_write_reg_async(struct usbnet *dev, u8 reg, u8 value) 66 66 { 67 - usbnet_write_cmd_async(dev, SR_WR_REG, SR_REQ_WR_REG, 67 + usbnet_write_cmd_async(dev, SR_WR_SINGLE_REG, SR_REQ_WR_REG, 68 68 value, reg, NULL, 0); 69 69 } 70 70
+2 -2
drivers/net/usb/sr9700.h
··· 150 150 151 151 /* Register access commands and flags */ 152 152 #define SR_RD_REGS 0x00 153 - #define SR_WR_REGS 0x01 154 - #define SR_WR_REG 0x03 153 + #define SR_WR_MULTIPLE_REGS 0x01 154 + #define SR_WR_SINGLE_REG 0x03 155 155 #define SR_REQ_RD_REG (USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE) 156 156 #define SR_REQ_WR_REG (USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE) 157 157