tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

HID: asus: early return for ROG devices

Some ROG devices have a new dynamic backlight interface for control by
Windows. This interface does not create an ->input device, causing the
kernel to print an error message and to eject it. In addition, ROG
devices have proper HID names in their descriptors so renaming them is
not necessary.

Therefore, if a device is identified as ROG, early return from probe to
skip renaming and ->input checks.

Acked-by: Benjamin Tissoires <bentiss@kernel.org>
Reviewed-by: Denis Benato <benato.denis96@gmail.com>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
Link: https://patch.msgid.link/20260122075044.5070-7-lkml@antheas.dev
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

authored by

Antheas Kapenekakis and committed by
Ilpo Järvinen 4ac74ea6 2b92b797

+7
+7
drivers/hid/hid-asus.c
··· 1233 1233 hid_warn(hdev, "Failed to initialize backlight.\n"); 1234 1234 1235 1235 /* 1236 + * For ROG keyboards, skip rename for consistency and ->input check as 1237 + * some devices do not have inputs. 1238 + */ 1239 + if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD) 1240 + return 0; 1241 + 1242 + /* 1236 1243 * Check that input registration succeeded. Checking that 1237 1244 * HID_CLAIMED_INPUT is set prevents a UAF when all input devices 1238 1245 * were freed during registration due to no usages being mapped,