tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: mscc: ocelot: fix memory leak on ocelot_port_add_txtstamp_skb()

If ocelot_port_add_txtstamp_skb() fails, for example due to a full PTP
timestamp FIFO, we must undo the skb_clone_sk() call with kfree_skb().
Otherwise, the reference to the skb clone is lost.

Fixes: 52849bcf0029 ("net: mscc: ocelot: avoid overflowing the PTP timestamp FIFO")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://patch.msgid.link/20241205145519.1236778-2-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Vladimir Oltean and committed by
Jakub Kicinski 4b01bec2 cdd0b913

+3 -1
+3 -1
drivers/net/ethernet/mscc/ocelot_ptp.c
··· 688 688 return -ENOMEM; 689 689 690 690 err = ocelot_port_add_txtstamp_skb(ocelot, port, *clone); 691 - if (err) 691 + if (err) { 692 + kfree_skb(*clone); 692 693 return err; 694 + } 693 695 694 696 OCELOT_SKB_CB(skb)->ptp_cmd = ptp_cmd; 695 697 OCELOT_SKB_CB(*clone)->ptp_class = ptp_class;