tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

rseq: Mark rseq_arm_slice_extension_timer() __always_inline

objtool warns about this function being called inside of a uaccess
section:

kernel/entry/common.o: warning: objtool: irqentry_exit+0x1dc: call to rseq_arm_slice_extension_timer() with UACCESS enabled

Interestingly, this happens with CONFIG_RSEQ_SLICE_EXTENSION disabled,
so this is an empty function, as the normal implementation is
already marked __always_inline.

I could reproduce this multiple times with gcc-11 but not with gcc-15,
so the compiler probably got better at identifying the trivial function.

Mark all the empty helpers for !RSEQ_SLICE_EXTENSION as __always_inline
for consistency, avoiding this warning.

Fixes: 0ac3b5c3dc45 ("rseq: Implement time slice extension enforcement timer")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://patch.msgid.link/20260206074122.709580-1-arnd@kernel.org

authored by

Arnd Bergmann and committed by
Peter Zijlstra 4c652a47 6e3c0a4e

+4 -4
+4 -4
include/linux/rseq_entry.h
··· 216 216 } 217 217 218 218 #else /* CONFIG_RSEQ_SLICE_EXTENSION */ 219 - static inline bool rseq_slice_extension_enabled(void) { return false; } 220 - static inline bool rseq_arm_slice_extension_timer(void) { return false; } 221 - static inline void rseq_slice_clear_grant(struct task_struct *t) { } 222 - static inline bool rseq_grant_slice_extension(bool work_pending) { return false; } 219 + static __always_inline bool rseq_slice_extension_enabled(void) { return false; } 220 + static __always_inline bool rseq_arm_slice_extension_timer(void) { return false; } 221 + static __always_inline void rseq_slice_clear_grant(struct task_struct *t) { } 222 + static __always_inline bool rseq_grant_slice_extension(bool work_pending) { return false; } 223 223 #endif /* !CONFIG_RSEQ_SLICE_EXTENSION */ 224 224 225 225 bool rseq_debug_update_user_cs(struct task_struct *t, struct pt_regs *regs, unsigned long csaddr);