tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

gpio: loongson-64bit: Fix a less than zero check on an unsigned int struct field

Currently the error check from the call to platform_get_irq is always
false because an unsigned int chip->irq.parents[i] is being used to
to perform the less than zero error check. Fix this by using the int
variable ret to perform the check.

Fixes: 03c146cb6cd1 ("gpio: loongson-64bit: Add support for Loongson-2K0300 SoC")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>
Reviewed-by: Yao Zi <ziyao@disroot.org>
Link: https://lore.kernel.org/r/20250909190356.870000-1-colin.i.king@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

authored by

Colin Ian King and committed by
Bartosz Golaszewski 4c91b0ee 52bdd696

+6 -3
+6 -3
drivers/gpio/gpio-loongson-64bit.c
··· 267 267 return -ENOMEM; 268 268 269 269 for (i = 0; i < data->intr_num; i++) { 270 - chip->irq.parents[i] = platform_get_irq(pdev, i); 271 - if (chip->irq.parents[i] < 0) 272 - return dev_err_probe(&pdev->dev, chip->irq.parents[i], 270 + int ret; 271 + 272 + ret = platform_get_irq(pdev, i); 273 + if (ret < 0) 274 + return dev_err_probe(&pdev->dev, ret, 273 275 "failed to get IRQ %d\n", i); 276 + chip->irq.parents[i] = ret; 274 277 } 275 278 276 279 for (i = 0; i < data->intr_num; i++) {