tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: airoha: Do not return err in ndo_stop() callback

Always complete the airoha_dev_stop() routine regardless of the
airoha_set_vip_for_gdm_port() return value, since errors from
ndo_stop() are ignored by the networking stack and the interface is
always considered down after the call.

Fixes: 23020f049327 ("net: airoha: Introduce ethernet support for EN7581 SoC")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Link: https://patch.msgid.link/20260428-airoha-ndo-stop-not-err-v1-1-674506d29a91@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Lorenzo Bianconi and committed by
Jakub Kicinski 4ca01292 b3168120

+2 -5
+2 -5
drivers/net/ethernet/airoha/airoha_eth.c
··· 1747 1747 { 1748 1748 struct airoha_gdm_port *port = netdev_priv(dev); 1749 1749 struct airoha_qdma *qdma = port->qdma; 1750 - int i, err; 1750 + int i; 1751 1751 1752 1752 netif_tx_disable(dev); 1753 - err = airoha_set_vip_for_gdm_port(port, false); 1754 - if (err) 1755 - return err; 1756 - 1753 + airoha_set_vip_for_gdm_port(port, false); 1757 1754 for (i = 0; i < dev->num_tx_queues; i++) 1758 1755 netdev_tx_reset_subqueue(dev, i); 1759 1756