tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

i3c: dw: use FIELD_PREP for device address table macros

Add DEV_ADDR_TABLE_DYNAMIC_MASK / DEV_ADDR_TABLE_DYNAMIC_ADDR(x) for
dynamic device addresses and DEV_ADDR_TABLE_STATIC_MASK /
DEV_ADDR_TABLE_STATIC_ADDR(x) for static device addresses in the I3C
address table. Replace manual shift-and-mask with FIELD_PREP() for both
dynamic and static addresses for clarity and maintainability.

Signed-off-by: Adrian Ng Ho Yin <adrianhoyin.ng@altera.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/d72896e510db1870d26a794f131f600c7e42cf00.1765529948.git.adrianhoyin.ng@altera.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

authored by

Adrian Ng Ho Yin and committed by
Alexandre Belloni 4cd9d2bf ec17f143

+4 -2
+4 -2
drivers/i3c/master/dw-i3c-master.c
··· 207 207 208 208 #define DW_I3C_DEV_NACK_RETRY_CNT_MAX 0x3 209 209 #define DEV_ADDR_TABLE_DEV_NACK_RETRY_MASK GENMASK(30, 29) 210 + #define DEV_ADDR_TABLE_DYNAMIC_MASK GENMASK(23, 16) 211 + #define DEV_ADDR_TABLE_STATIC_MASK GENMASK(6, 0) 210 212 #define DEV_ADDR_TABLE_IBI_MDB BIT(12) 211 213 #define DEV_ADDR_TABLE_SIR_REJECT BIT(13) 212 214 #define DEV_ADDR_TABLE_DEV_NACK_RETRY_CNT(x) \ 213 215 FIELD_PREP(DEV_ADDR_TABLE_DEV_NACK_RETRY_MASK, (x)) 214 216 #define DEV_ADDR_TABLE_LEGACY_I2C_DEV BIT(31) 215 - #define DEV_ADDR_TABLE_DYNAMIC_ADDR(x) (((x) << 16) & GENMASK(23, 16)) 216 - #define DEV_ADDR_TABLE_STATIC_ADDR(x) ((x) & GENMASK(6, 0)) 217 + #define DEV_ADDR_TABLE_DYNAMIC_ADDR(x) FIELD_PREP(DEV_ADDR_TABLE_DYNAMIC_MASK, x) 218 + #define DEV_ADDR_TABLE_STATIC_ADDR(x) FIELD_PREP(DEV_ADDR_TABLE_STATIC_MASK, x) 217 219 #define DEV_ADDR_TABLE_LOC(start, idx) ((start) + ((idx) << 2)) 218 220 219 221 #define I3C_BUS_SDR1_SCL_RATE 8000000