Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
KVM: arm64: Wake-up from WFI when iqrchip is in userspace
It appears that there is nothing in the wake-up path that
evaluates whether the in-kernel interrupts are pending unless
we have a vgic.
This means that the userspace irqchip support has been broken for
about four years, and nobody noticed. It was also broken before
as we wouldn't wake-up on a PMU interrupt, but hey, who cares...
It is probably time to remove the feature altogether, because it
was a terrible idea 10 years ago, and it still is.
Fixes: b57de4ffd7c6d ("KVM: arm64: Simplify kvm_cpu_has_pending_timer()")
Link: https://patch.msgid.link/20260423163607.486345-1-maz@kernel.org
Signed-off-by: Marc Zyngier <maz@kernel.org>
Cc: stable@vger.kernel.org
+4
+4
arch/arm64/kvm/arm.c
+4
arch/arm64/kvm/arm.c
···
824
824
{
825
825
bool irq_lines = *vcpu_hcr(v) & (HCR_VI | HCR_VF | HCR_VSE);
826
826
827
+
irq_lines |= (!irqchip_in_kernel(v->kvm) &&
828
+
(kvm_timer_should_notify_user(v) ||
829
+
kvm_pmu_should_notify_user(v)));
830
+
827
831
return ((irq_lines || kvm_vgic_vcpu_pending_irq(v))
828
832
&& !kvm_arm_vcpu_stopped(v) && !v->arch.pause);
829
833
}