Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

powerpc/64: Disable irq restore warning for now

We recently added a warning in arch_local_irq_restore() to check that
the soft masking state matches reality.

Unfortunately it trips in a few places, which are not entirely trivial
to fix. The key problem is if we're doing function_graph tracing of
restore_math(), the warning pops and then seems to recurse. It's not
entirely clear because the system continuously oopses on all CPUs,
with the output interleaved and unreadable.

It's also been observed on a G5 coming out of idle.

Until we can fix those cases disable the warning for now.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

+10 -3
+10 -3
arch/powerpc/kernel/irq.c
··· 261 261 */ 262 262 irq_happened = get_irq_happened(); 263 263 if (!irq_happened) { 264 - #ifdef CONFIG_PPC_IRQ_SOFT_MASK_DEBUG 265 - WARN_ON(!(mfmsr() & MSR_EE)); 266 - #endif 264 + /* 265 + * FIXME. Here we'd like to be able to do: 266 + * 267 + * #ifdef CONFIG_PPC_IRQ_SOFT_MASK_DEBUG 268 + * WARN_ON(!(mfmsr() & MSR_EE)); 269 + * #endif 270 + * 271 + * But currently it hits in a few paths, we should fix those and 272 + * enable the warning. 273 + */ 267 274 return; 268 275 } 269 276