tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

VFS: move the start_dirop() kerndoc comment to before start_dirop()

This kerneldoc comment was always meant for start_dirop(), not for
__start_dirop() which is a static function and doesn't need
documentation.

It was in the wrong place and was then incorrectly renamed (instead of
moved) and useless "documentation" was added for "@state" was provided.

This patch reverts the name, removes the mention of @state, and moves
the comment to where it belongs.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: NeilBrown <neil@brown.name>
Link: https://patch.msgid.link/20260224222542.3458677-4-neilb@ownmail.net
Signed-off-by: Christian Brauner <brauner@kernel.org>

authored by

NeilBrown and committed by
Christian Brauner 4eb94abd 9ab68389

+13 -14
+13 -14
fs/namei.c
··· 2893 2893 return __filename_parentat(dfd, name, flags, parent, last, type, NULL); 2894 2894 } 2895 2895 2896 - /** 2897 - * __start_dirop - begin a create or remove dirop, performing locking and lookup 2898 - * @parent: the dentry of the parent in which the operation will occur 2899 - * @name: a qstr holding the name within that parent 2900 - * @lookup_flags: intent and other lookup flags. 2901 - * @state: task state bitmask 2902 - * 2903 - * The lookup is performed and necessary locks are taken so that, on success, 2904 - * the returned dentry can be operated on safely. 2905 - * The qstr must already have the hash value calculated. 2906 - * 2907 - * Returns: a locked dentry, or an error. 2908 - * 2909 - */ 2910 2896 static struct dentry *__start_dirop(struct dentry *parent, struct qstr *name, 2911 2897 unsigned int lookup_flags, 2912 2898 unsigned int state) ··· 2914 2928 return dentry; 2915 2929 } 2916 2930 2931 + /** 2932 + * start_dirop - begin a create or remove dirop, performing locking and lookup 2933 + * @parent: the dentry of the parent in which the operation will occur 2934 + * @name: a qstr holding the name within that parent 2935 + * @lookup_flags: intent and other lookup flags. 2936 + * 2937 + * The lookup is performed and necessary locks are taken so that, on success, 2938 + * the returned dentry can be operated on safely. 2939 + * The qstr must already have the hash value calculated. 2940 + * 2941 + * Returns: a locked dentry, or an error. 2942 + * 2943 + */ 2917 2944 struct dentry *start_dirop(struct dentry *parent, struct qstr *name, 2918 2945 unsigned int lookup_flags) 2919 2946 {