Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
crypto: caam - Avoid GCC memset bug warning
Certain versions of gcc don't like the memcpy with a NULL dst
(which only happens with a zero length). This only happens
when debugging is enabled so add an if clause to work around
these warnings.
A similar warning used to be generated by sparse but that was
fixed years ago.
Link: https://lore.kernel.org/lkml/202210290446.qBayTfzl-lkp@intel.com
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Kees Cook <keescook@chromium.org>
Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
+2
-1
+2
-1
drivers/crypto/caam/desc_constr.h
+2
-1
drivers/crypto/caam/desc_constr.h
···
163
163
{
164
164
u32 *offset = desc_end(desc);
165
165
166
-
if (len) /* avoid sparse warning: memcpy with byte count of 0 */
166
+
/* Avoid gcc warning: memcpy with data == NULL */
167
+
if (!IS_ENABLED(CONFIG_CRYPTO_DEV_FSL_CAAM_DEBUG) || data)
167
168
memcpy(offset, data, len);
168
169
169
170
(*desc) = cpu_to_caam32(caam32_to_cpu(*desc) +