tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/msm: msm_fence.h: fix all kernel-doc warnings

Correct or add kernel-doc comments to eliminate all warnings:

Warning: drivers/gpu/drm/msm/msm_fence.h:27 Incorrect use of kernel-doc
format: * last_fence:
Warning: drivers/gpu/drm/msm/msm_fence.h:36 Incorrect use of kernel-doc
format: * completed_fence:
Warning: drivers/gpu/drm/msm/msm_fence.h:44 Incorrect use of kernel-doc
format: * fenceptr:
Warning: drivers/gpu/drm/msm/msm_fence.h:65 Incorrect use of kernel-doc
format: * next_deadline_fence:
Warning: drivers/gpu/drm/msm/msm_fence.h:74 struct member 'dev' not
described in 'msm_fence_context'
Warning: drivers/gpu/drm/msm/msm_fence.h:74 struct member 'name' not
described in 'msm_fence_context'
Warning: drivers/gpu/drm/msm/msm_fence.h:74 struct member 'context' not
described in 'msm_fence_context'
Warning: drivers/gpu/drm/msm/msm_fence.h:74 struct member 'index' not
described in 'msm_fence_context'
Warning: drivers/gpu/drm/msm/msm_fence.h:74 struct member 'fence' not
described in 'msm_fence_context'
Warning: drivers/gpu/drm/msm/msm_fence.h:74 struct member 'there is no
remaining pending work */ uint32_t last_fence' not described in
'msm_fence_context'
Warning: drivers/gpu/drm/msm/msm_fence.h:74 struct member 'updated from the CPU after interrupt * from GPU */ uint32_t completed_fence' not described in 'msm_fence_context'
Warning: drivers/gpu/drm/msm/msm_fence.h:74 struct member 'fenceptr' not
described in 'msm_fence_context'
Warning: drivers/gpu/drm/msm/msm_fence.h:74 struct member 'spinlock' not
described in 'msm_fence_context'
Warning: drivers/gpu/drm/msm/msm_fence.h:74 struct member 'next_deadline'
not described in 'msm_fence_context'
Warning: drivers/gpu/drm/msm/msm_fence.h:74 struct member
'next_deadline_fence' not described in 'msm_fence_context'
Warning: drivers/gpu/drm/msm/msm_fence.h:74 struct member 'deadline_timer'
not described in 'msm_fence_context'
Warning: drivers/gpu/drm/msm/msm_fence.h:74 struct member 'deadline_work'
not described in 'msm_fence_context'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/695667/
Link: https://lore.kernel.org/r/20251219184638.1813181-17-rdunlap@infradead.org
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

authored by

Randy Dunlap and committed by
Dmitry Baryshkov 4fc510e5 a6ccad66

+19 -17
+19 -17
drivers/gpu/drm/msm/msm_fence.h
··· 16 16 * incrementing fence seqno at the end of each submit 17 17 */ 18 18 struct msm_fence_context { 19 + /** @dev: the drm device */ 19 20 struct drm_device *dev; 20 - /** name: human readable name for fence timeline */ 21 + /** @name: human readable name for fence timeline */ 21 22 char name[32]; 22 - /** context: see dma_fence_context_alloc() */ 23 + /** @context: see dma_fence_context_alloc() */ 23 24 unsigned context; 24 - /** index: similar to context, but local to msm_fence_context's */ 25 + /** @index: similar to context, but local to msm_fence_context's */ 25 26 unsigned index; 26 - 27 27 /** 28 - * last_fence: 29 - * 28 + * @last_fence: 30 29 * Last assigned fence, incremented each time a fence is created 31 30 * on this fence context. If last_fence == completed_fence, 32 31 * there is no remaining pending work 33 32 */ 34 33 uint32_t last_fence; 35 - 36 34 /** 37 - * completed_fence: 38 - * 35 + * @completed_fence: 39 36 * The last completed fence, updated from the CPU after interrupt 40 37 * from GPU 41 38 */ 42 39 uint32_t completed_fence; 43 - 44 40 /** 45 - * fenceptr: 46 - * 41 + * @fenceptr: 47 42 * The address that the GPU directly writes with completed fence 48 43 * seqno. This can be ahead of completed_fence. We can peek at 49 44 * this to see if a fence has already signaled but the CPU hasn't ··· 46 51 */ 47 52 volatile uint32_t *fenceptr; 48 53 54 + /** 55 + * @spinlock: fence context spinlock 56 + */ 49 57 spinlock_t spinlock; 50 58 51 59 /* ··· 57 59 * don't queue, so maybe that is ok 58 60 */ 59 61 60 - /** next_deadline: Time of next deadline */ 62 + /** @next_deadline: Time of next deadline */ 61 63 ktime_t next_deadline; 62 - 63 64 /** 64 - * next_deadline_fence: 65 - * 65 + * @next_deadline_fence: 66 66 * Fence value for next pending deadline. The deadline timer is 67 67 * canceled when this fence is signaled. 68 68 */ 69 69 uint32_t next_deadline_fence; 70 - 70 + /** 71 + * @deadline_timer: tracks nearest deadline of a fence timeline and 72 + * expires just before it. 73 + */ 71 74 struct hrtimer deadline_timer; 75 + /** 76 + * @deadline_work: work to do after deadline_timer expires 77 + */ 72 78 struct kthread_work deadline_work; 73 79 }; 74 80