Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
lib: add tests for mul_u64_u64_div_u64_roundup()
Replicate the existing mul_u64_u64_div_u64() test cases with round up.
Update the shell script that verifies the table, remove the comment
markers so that it can be directly pasted into a shell.
Rename the divisor from 'c' to 'd' to match mul_u64_add_u64_div_u64().
It any tests fail then fail the module load with -EINVAL.
Link: https://lkml.kernel.org/r/20251105201035.64043-6-david.laight.linux@gmail.com
Signed-off-by: David Laight <david.laight.linux@gmail.com>
Reviewed-by: Nicolas Pitre <npitre@baylibre.com>
Cc: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Borislav Betkov <bp@alien8.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Li RongQing <lirongqing@baidu.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleinxer <tglx@linutronix.de>
Cc: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
authored by
David Laight
and committed by
Andrew Morton
500db219
6480241f
+73
-49
+73
-49
lib/math/test_mul_u64_u64_div_u64.c
+73
-49
lib/math/test_mul_u64_u64_div_u64.c
···
10
10
#include <linux/printk.h>
11
11
#include <linux/math64.h>
12
12
13
-
typedef struct { u64 a; u64 b; u64 c; u64 result; } test_params;
13
+
typedef struct { u64 a; u64 b; u64 d; u64 result; uint round_up;} test_params;
14
14
15
15
static test_params test_values[] = {
16
16
/* this contains many edge values followed by a couple random values */
17
-
{ 0xb, 0x7, 0x3, 0x19 },
18
-
{ 0xffff0000, 0xffff0000, 0xf, 0x1110eeef00000000 },
19
-
{ 0xffffffff, 0xffffffff, 0x1, 0xfffffffe00000001 },
20
-
{ 0xffffffff, 0xffffffff, 0x2, 0x7fffffff00000000 },
21
-
{ 0x1ffffffff, 0xffffffff, 0x2, 0xfffffffe80000000 },
22
-
{ 0x1ffffffff, 0xffffffff, 0x3, 0xaaaaaaa9aaaaaaab },
23
-
{ 0x1ffffffff, 0x1ffffffff, 0x4, 0xffffffff00000000 },
24
-
{ 0xffff000000000000, 0xffff000000000000, 0xffff000000000001, 0xfffeffffffffffff },
25
-
{ 0x3333333333333333, 0x3333333333333333, 0x5555555555555555, 0x1eb851eb851eb851 },
26
-
{ 0x7fffffffffffffff, 0x2, 0x3, 0x5555555555555554 },
27
-
{ 0xffffffffffffffff, 0x2, 0x8000000000000000, 0x3 },
28
-
{ 0xffffffffffffffff, 0x2, 0xc000000000000000, 0x2 },
29
-
{ 0xffffffffffffffff, 0x4000000000000004, 0x8000000000000000, 0x8000000000000007 },
30
-
{ 0xffffffffffffffff, 0x4000000000000001, 0x8000000000000000, 0x8000000000000001 },
31
-
{ 0xffffffffffffffff, 0x8000000000000001, 0xffffffffffffffff, 0x8000000000000001 },
32
-
{ 0xfffffffffffffffe, 0x8000000000000001, 0xffffffffffffffff, 0x8000000000000000 },
33
-
{ 0xffffffffffffffff, 0x8000000000000001, 0xfffffffffffffffe, 0x8000000000000001 },
34
-
{ 0xffffffffffffffff, 0x8000000000000001, 0xfffffffffffffffd, 0x8000000000000002 },
35
-
{ 0x7fffffffffffffff, 0xffffffffffffffff, 0xc000000000000000, 0xaaaaaaaaaaaaaaa8 },
36
-
{ 0xffffffffffffffff, 0x7fffffffffffffff, 0xa000000000000000, 0xccccccccccccccca },
37
-
{ 0xffffffffffffffff, 0x7fffffffffffffff, 0x9000000000000000, 0xe38e38e38e38e38b },
38
-
{ 0x7fffffffffffffff, 0x7fffffffffffffff, 0x5000000000000000, 0xccccccccccccccc9 },
39
-
{ 0xffffffffffffffff, 0xfffffffffffffffe, 0xffffffffffffffff, 0xfffffffffffffffe },
40
-
{ 0xe6102d256d7ea3ae, 0x70a77d0be4c31201, 0xd63ec35ab3220357, 0x78f8bf8cc86c6e18 },
41
-
{ 0xf53bae05cb86c6e1, 0x3847b32d2f8d32e0, 0xcfd4f55a647f403c, 0x42687f79d8998d35 },
42
-
{ 0x9951c5498f941092, 0x1f8c8bfdf287a251, 0xa3c8dc5f81ea3fe2, 0x1d887cb25900091f },
43
-
{ 0x374fee9daa1bb2bb, 0x0d0bfbff7b8ae3ef, 0xc169337bd42d5179, 0x03bb2dbaffcbb961 },
44
-
{ 0xeac0d03ac10eeaf0, 0x89be05dfa162ed9b, 0x92bb1679a41f0e4b, 0xdc5f5cc9e270d216 },
17
+
{ 0xb, 0x7, 0x3, 0x19, 1 },
18
+
{ 0xffff0000, 0xffff0000, 0xf, 0x1110eeef00000000, 0 },
19
+
{ 0xffffffff, 0xffffffff, 0x1, 0xfffffffe00000001, 0 },
20
+
{ 0xffffffff, 0xffffffff, 0x2, 0x7fffffff00000000, 1 },
21
+
{ 0x1ffffffff, 0xffffffff, 0x2, 0xfffffffe80000000, 1 },
22
+
{ 0x1ffffffff, 0xffffffff, 0x3, 0xaaaaaaa9aaaaaaab, 0 },
23
+
{ 0x1ffffffff, 0x1ffffffff, 0x4, 0xffffffff00000000, 1 },
24
+
{ 0xffff000000000000, 0xffff000000000000, 0xffff000000000001, 0xfffeffffffffffff, 1 },
25
+
{ 0x3333333333333333, 0x3333333333333333, 0x5555555555555555, 0x1eb851eb851eb851, 1 },
26
+
{ 0x7fffffffffffffff, 0x2, 0x3, 0x5555555555555554, 1 },
27
+
{ 0xffffffffffffffff, 0x2, 0x8000000000000000, 0x3, 1 },
28
+
{ 0xffffffffffffffff, 0x2, 0xc000000000000000, 0x2, 1 },
29
+
{ 0xffffffffffffffff, 0x4000000000000004, 0x8000000000000000, 0x8000000000000007, 1 },
30
+
{ 0xffffffffffffffff, 0x4000000000000001, 0x8000000000000000, 0x8000000000000001, 1 },
31
+
{ 0xffffffffffffffff, 0x8000000000000001, 0xffffffffffffffff, 0x8000000000000001, 0 },
32
+
{ 0xfffffffffffffffe, 0x8000000000000001, 0xffffffffffffffff, 0x8000000000000000, 1 },
33
+
{ 0xffffffffffffffff, 0x8000000000000001, 0xfffffffffffffffe, 0x8000000000000001, 1 },
34
+
{ 0xffffffffffffffff, 0x8000000000000001, 0xfffffffffffffffd, 0x8000000000000002, 1 },
35
+
{ 0x7fffffffffffffff, 0xffffffffffffffff, 0xc000000000000000, 0xaaaaaaaaaaaaaaa8, 1 },
36
+
{ 0xffffffffffffffff, 0x7fffffffffffffff, 0xa000000000000000, 0xccccccccccccccca, 1 },
37
+
{ 0xffffffffffffffff, 0x7fffffffffffffff, 0x9000000000000000, 0xe38e38e38e38e38b, 1 },
38
+
{ 0x7fffffffffffffff, 0x7fffffffffffffff, 0x5000000000000000, 0xccccccccccccccc9, 1 },
39
+
{ 0xffffffffffffffff, 0xfffffffffffffffe, 0xffffffffffffffff, 0xfffffffffffffffe, 0 },
40
+
{ 0xe6102d256d7ea3ae, 0x70a77d0be4c31201, 0xd63ec35ab3220357, 0x78f8bf8cc86c6e18, 1 },
41
+
{ 0xf53bae05cb86c6e1, 0x3847b32d2f8d32e0, 0xcfd4f55a647f403c, 0x42687f79d8998d35, 1 },
42
+
{ 0x9951c5498f941092, 0x1f8c8bfdf287a251, 0xa3c8dc5f81ea3fe2, 0x1d887cb25900091f, 1 },
43
+
{ 0x374fee9daa1bb2bb, 0x0d0bfbff7b8ae3ef, 0xc169337bd42d5179, 0x03bb2dbaffcbb961, 1 },
44
+
{ 0xeac0d03ac10eeaf0, 0x89be05dfa162ed9b, 0x92bb1679a41f0e4b, 0xdc5f5cc9e270d216, 1 },
45
45
};
46
46
47
47
/*
48
48
* The above table can be verified with the following shell script:
49
-
*
50
-
* #!/bin/sh
51
-
* sed -ne 's/^{ \+\(.*\), \+\(.*\), \+\(.*\), \+\(.*\) },$/\1 \2 \3 \4/p' \
52
-
* lib/math/test_mul_u64_u64_div_u64.c |
53
-
* while read a b c r; do
54
-
* expected=$( printf "obase=16; ibase=16; %X * %X / %X\n" $a $b $c | bc )
55
-
* given=$( printf "%X\n" $r )
56
-
* if [ "$expected" = "$given" ]; then
57
-
* echo "$a * $b / $c = $r OK"
58
-
* else
59
-
* echo "$a * $b / $c = $r is wrong" >&2
60
-
* echo "should be equivalent to 0x$expected" >&2
61
-
* exit 1
62
-
* fi
63
-
* done
49
+
50
+
#!/bin/sh
51
+
sed -ne 's/^{ \+\(.*\), \+\(.*\), \+\(.*\), \+\(.*\), \+\(.*\) },$/\1 \2 \3 \4 \5/p' \
52
+
lib/math/test_mul_u64_u64_div_u64.c |
53
+
while read a b d r e; do
54
+
expected=$( printf "obase=16; ibase=16; %X * %X / %X\n" $a $b $d | bc )
55
+
given=$( printf "%X\n" $r )
56
+
if [ "$expected" = "$given" ]; then
57
+
echo "$a * $b / $d = $r OK"
58
+
else
59
+
echo "$a * $b / $d = $r is wrong" >&2
60
+
echo "should be equivalent to 0x$expected" >&2
61
+
exit 1
62
+
fi
63
+
expected=$( printf "obase=16; ibase=16; (%X * %X + %X) / %X\n" $a $b $((d-1)) $d | bc )
64
+
given=$( printf "%X\n" $((r + e)) )
65
+
if [ "$expected" = "$given" ]; then
66
+
echo "$a * $b +/ $d = $(printf '%#x' $((r + e))) OK"
67
+
else
68
+
echo "$a * $b +/ $d = $(printf '%#x' $((r + e))) is wrong" >&2
69
+
echo "should be equivalent to 0x$expected" >&2
70
+
exit 1
71
+
fi
72
+
done
73
+
64
74
*/
65
75
66
76
static int __init test_init(void)
67
77
{
78
+
int errors = 0;
79
+
int tests = 0;
68
80
int i;
69
81
70
82
pr_info("Starting mul_u64_u64_div_u64() test\n");
···
84
72
for (i = 0; i < ARRAY_SIZE(test_values); i++) {
85
73
u64 a = test_values[i].a;
86
74
u64 b = test_values[i].b;
87
-
u64 c = test_values[i].c;
75
+
u64 d = test_values[i].d;
88
76
u64 expected_result = test_values[i].result;
89
-
u64 result = mul_u64_u64_div_u64(a, b, c);
77
+
u64 result = mul_u64_u64_div_u64(a, b, d);
78
+
u64 result_up = mul_u64_u64_div_u64_roundup(a, b, d);
79
+
80
+
tests += 2;
90
81
91
82
if (result != expected_result) {
92
-
pr_err("ERROR: 0x%016llx * 0x%016llx / 0x%016llx\n", a, b, c);
83
+
pr_err("ERROR: 0x%016llx * 0x%016llx / 0x%016llx\n", a, b, d);
93
84
pr_err("ERROR: expected result: %016llx\n", expected_result);
94
85
pr_err("ERROR: obtained result: %016llx\n", result);
86
+
errors++;
87
+
}
88
+
expected_result += test_values[i].round_up;
89
+
if (result_up != expected_result) {
90
+
pr_err("ERROR: 0x%016llx * 0x%016llx +/ 0x%016llx\n", a, b, d);
91
+
pr_err("ERROR: expected result: %016llx\n", expected_result);
92
+
pr_err("ERROR: obtained result: %016llx\n", result_up);
93
+
errors++;
95
94
}
96
95
}
97
96
98
-
pr_info("Completed mul_u64_u64_div_u64() test\n");
99
-
return 0;
97
+
pr_info("Completed mul_u64_u64_div_u64() test, %d tests, %d errors\n",
98
+
tests, errors);
99
+
return errors ? -EINVAL : 0;
100
100
}
101
101
102
102
static void __exit test_exit(void)