tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

btrfs: fix incorrect key offset in error message in check_dev_extent_item()

Fix the error message in check_dev_extent_item(), when an overlapping
stripe is encountered. For dev extents, objectid is the disk number and
offset the physical address, so prev_key->objectid should actually be
prev_key->offset.

(I can't take any credit for this one - this was discovered by Chris and
his friend Claude.)

Reported-by: Chris Mason <clm@fb.com>
Fixes: 008e2512dc56 ("btrfs: tree-checker: add dev extent item checks")
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Mark Harmstone <mark@harmstone.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

authored by

Mark Harmstone and committed by
David Sterba 511dc891 3cf0f357

+1 -1
+1 -1
fs/btrfs/tree-checker.c
··· 1921 1921 if (unlikely(prev_key->offset + prev_len > key->offset)) { 1922 1922 generic_err(leaf, slot, 1923 1923 "dev extent overlap, prev offset %llu len %llu current offset %llu", 1924 - prev_key->objectid, prev_len, key->offset); 1924 + prev_key->offset, prev_len, key->offset); 1925 1925 return -EUCLEAN; 1926 1926 } 1927 1927 }