tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/rockchip: dw_hdmi: Use dev_err_probe() to simplify code

In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs.

Signed-off-by: Yumeng Fang <fang.yumeng@zte.com.cn>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20250515203554564-j1jBXUXR6bdiN6zARicC@zte.com.cn

authored by

Yumeng Fang and committed by
Heiko Stuebner 52008d6f afbbca25

+4 -12
+4 -12
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
··· 213 213 214 214 if (IS_ERR(hdmi->ref_clk)) { 215 215 ret = PTR_ERR(hdmi->ref_clk); 216 - if (ret != -EPROBE_DEFER) 217 - dev_err(hdmi->dev, "failed to get reference clock\n"); 218 - return ret; 216 + return dev_err_probe(hdmi->dev, ret, "failed to get reference clock\n"); 219 217 } 220 218 221 219 hdmi->grf_clk = devm_clk_get_optional(hdmi->dev, "grf"); 222 220 if (IS_ERR(hdmi->grf_clk)) { 223 221 ret = PTR_ERR(hdmi->grf_clk); 224 - if (ret != -EPROBE_DEFER) 225 - dev_err(hdmi->dev, "failed to get grf clock\n"); 226 - return ret; 222 + return dev_err_probe(hdmi->dev, ret, "failed to get grf clock\n"); 227 223 } 228 224 229 225 ret = devm_regulator_get_enable(hdmi->dev, "avdd-0v9"); ··· 569 573 570 574 ret = rockchip_hdmi_parse_dt(hdmi); 571 575 if (ret) { 572 - if (ret != -EPROBE_DEFER) 573 - dev_err(hdmi->dev, "Unable to parse OF data\n"); 574 - return ret; 576 + return dev_err_probe(hdmi->dev, ret, "Unable to parse OF data\n"); 575 577 } 576 578 577 579 hdmi->phy = devm_phy_optional_get(dev, "hdmi"); 578 580 if (IS_ERR(hdmi->phy)) { 579 581 ret = PTR_ERR(hdmi->phy); 580 - if (ret != -EPROBE_DEFER) 581 - dev_err(hdmi->dev, "failed to get phy\n"); 582 - return ret; 582 + return dev_err_probe(hdmi->dev, ret, "failed to get phy\n"); 583 583 } 584 584 585 585 if (hdmi->phy) {