tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

floppy: use __bio_add_page for adding single page to bio

The floppy code uses bio_add_page() to add a page to a newly created bio.
bio_add_page() can fail, but the return value is never checked.

Use __bio_add_page() as adding a single page to a newly created bio is
guaranteed to succeed.

This brings us a step closer to marking bio_add_page() as __must_check.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Link: https://lore.kernel.org/r/33c445a3b431270c72d9be03d5da1b08ae983920.1685532726.git.johannes.thumshirn@wdc.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>

authored by

Johannes Thumshirn and committed by
Jens Axboe 5225229b 34848c91

+1 -1
+1 -1
drivers/block/floppy.c
··· 4147 4147 cbdata.drive = drive; 4148 4148 4149 4149 bio_init(&bio, bdev, &bio_vec, 1, REQ_OP_READ); 4150 - bio_add_page(&bio, page, block_size(bdev), 0); 4150 + __bio_add_page(&bio, page, block_size(bdev), 0); 4151 4151 4152 4152 bio.bi_iter.bi_sector = 0; 4153 4153 bio.bi_flags |= (1 << BIO_QUIET);