Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
drm/panthor: Don't try to enable extract events
Not only this only works once, because of how extract events work
(event is enabled if the req and ack bit differ, and it's signalled
by the FW by setting identical req and ack, to re-enable the event,
we need to toggle the bit, which we never do). But more importantly,
we never do anything with this event, so we're better off dropping it
when programming the CS slot.
v2:
- Add R-b
v3:
- Collect R-b
Reviewed-by: Steven Price <steven.price@arm.com>
Reviewed-by: Chia-I Wu <olvaffe@gmail.com>
Link: https://patch.msgid.link/20251128094839.3856402-3-boris.brezillon@collabora.com
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
+2
-4
+2
-4
drivers/gpu/drm/panthor/panthor_sched.c
+2
-4
drivers/gpu/drm/panthor/panthor_sched.c
···
1180
1180
panthor_fw_update_reqs(cs_iface, req,
1181
1181
CS_IDLE_SYNC_WAIT |
1182
1182
CS_IDLE_EMPTY |
1183
-
CS_STATE_START |
1184
-
CS_EXTRACT_EVENT,
1183
+
CS_STATE_START,
1185
1184
CS_IDLE_SYNC_WAIT |
1186
1185
CS_IDLE_EMPTY |
1187
-
CS_STATE_MASK |
1188
-
CS_EXTRACT_EVENT);
1186
+
CS_STATE_MASK);
1189
1187
if (queue->iface.input->insert != queue->iface.input->extract)
1190
1188
queue_resume_timeout(queue);
1191
1189
}