tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm: of: Fix linking when CONFIG_OF is not set

The new helper drm_of_lvds_get_dual_link_pixel_order() introduced in
commit 6529007522de has a fallback stub when CONFIG_OF is not set, but
the stub is declared in drm_of.h without a static inline. This causes
multiple definitions of the function to be linked when the CONFIG_OF
option isn't set. Fix it by making the stub static inline.

Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191219103703.8547-1-laurent.pinchart+renesas@ideasonboard.com

authored by

Laurent Pinchart and committed by
Dave Airlie 528d06d4 f5c547ef

+3 -2
+3 -2
include/drm/drm_of.h
··· 92 92 return -EINVAL; 93 93 } 94 94 95 - int drm_of_lvds_get_dual_link_pixel_order(const struct device_node *port1, 96 - const struct device_node *port2) 95 + static inline int 96 + drm_of_lvds_get_dual_link_pixel_order(const struct device_node *port1, 97 + const struct device_node *port2) 97 98 { 98 99 return -EINVAL; 99 100 }