Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ethtool.h: Replace zero-length array with flexible-array member

The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
int stuff;
struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by
this change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

+2 -2
+2 -2
include/linux/ethtool.h
··· 35 35 compat_u64 data; 36 36 struct compat_ethtool_rx_flow_spec fs; 37 37 u32 rule_cnt; 38 - u32 rule_locs[0]; 38 + u32 rule_locs[]; 39 39 }; 40 40 41 41 #endif /* CONFIG_COMPAT */ ··· 462 462 463 463 struct ethtool_rx_flow_rule { 464 464 struct flow_rule *rule; 465 - unsigned long priv[0]; 465 + unsigned long priv[]; 466 466 }; 467 467 468 468 struct ethtool_rx_flow_spec_input {