tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

staging/speakup: Update TODO list

Thanks to Okash's latest work, the TODO list is essentially empty, so
the way out from staging now seems open.

The status of the remaining issue mentioned in TODO is not clear, we
asked the speakup user mailing list for reproducer cases, but didn't get
a really specific scenario. One serious bug was fixed by 9d32c0cde4e2
("staging/speakup: fix get_word non-space look-ahead"), which does not
seem to really be related to the bug mentioned in TODO. Possibly the bug
mentioned in TODO has been fixed long ago and people have been thinking
that it was not because they can not distinguish the symptoms mentioned
in TODO from the symptoms of the bug fixed by 9d32c0cde4e2.

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Link: https://lore.kernel.org/r/20200726165452.qhos3wrjcm6jmcmx@function
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Samuel Thibault and committed by
Greg Kroah-Hartman 53754e43 9038c6ac

+6 -31
+6 -31
drivers/staging/speakup/TODO
··· 6 6 system. It allows blind users to interact with applications on the 7 7 linux console by means of synthetic speech. 8 8 9 - Currently, speakup has several issues we know of. 9 + Currently, speakup has one issue we know of. 10 10 11 - The first issue has to do with the way speakup communicates with serial 12 - ports. Currently, we communicate directly with the hardware 13 - ports. This however conflicts with the standard serial port drivers, 14 - which poses various problems. This is also not working for modern hardware 15 - such as PCI-based serial ports. Also, there is not a way we can 16 - communicate with USB devices. The current serial port handling code is 17 - in serialio.c in this directory. 18 - 19 - Some places are currently using in_atomic() because speakup functions 20 - are called in various contexts, and a couple of things can't happen 21 - in these cases. Pushing work to some worker thread would probably help, 22 - as was already done for the serial port driving part. 23 - 24 - There is a duplication of the selection functions in selections.c. These 25 - functions should get exported from drivers/char/selection.c (clear_selection 26 - notably) and used from there instead. 27 - 28 - The kobjects may have to move to a more proper place in /sys. The 29 - discussion on lkml resulted to putting speech synthesizers in the 30 - "speech" class, and the speakup screen reader itself into 31 - /sys/class/vtconsole/vtcon0/speakup, the nasty path being handled by 32 - userland tools. 33 - 34 - Another issue seems to only happen on SMP systems. It seems 35 - that text in the output buffer gets garbled because a lock is not set. 36 - This bug happens regularly, but no one has been able to find a situation 37 - which produces it consistently. 11 + It seems to only happen on SMP systems. It seems that text in the output buffer 12 + gets garbled because a lock is not set. This bug happens regularly, but no one 13 + has been able to find a situation which produces it consistently. 38 14 39 15 Patches, suggestions, corrections, etc, are definitely welcome. 40 16 ··· 18 42 not want to subscribe to a mailing list, send your email to all of the 19 43 following: 20 44 21 - w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca and 22 - samuel.thibault@ens-lyon.org. 23 - 45 + okash.khawaja@gmail.com, w.d.hubbs@gmail.com, chris@the-brannons.com, 46 + kirk@reisers.ca and samuel.thibault@ens-lyon.org.