Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

fix ptrace slowness

This patch fixes bug #12208:

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12208
Subject : uml is very slow on 2.6.28 host

This turned out to be not a scheduler regression, but an already
existing problem in ptrace being triggered by subtle scheduler
changes.

The problem is this:

- task A is ptracing task B
- task B stops on a trace event
- task A is woken up and preempts task B
- task A calls ptrace on task B, which does ptrace_check_attach()
- this calls wait_task_inactive(), which sees that task B is still on the runq
- task A goes to sleep for a jiffy
- ...

Since UML does lots of the above sequences, those jiffies quickly add
up to make it slow as hell.

This patch solves this by not rescheduling in read_unlock() after
ptrace_stop() has woken up the tracer.

Thanks to Oleg Nesterov and Ingo Molnar for the feedback.

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
CC: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Miklos Szeredi and committed by
Linus Torvalds
53da1d94 b0dcb4a9

+8
+8
kernel/signal.c
··· 1575 1575 read_lock(&tasklist_lock); 1576 1576 if (may_ptrace_stop()) { 1577 1577 do_notify_parent_cldstop(current, CLD_TRAPPED); 1578 + /* 1579 + * Don't want to allow preemption here, because 1580 + * sys_ptrace() needs this task to be inactive. 1581 + * 1582 + * XXX: implement read_unlock_no_resched(). 1583 + */ 1584 + preempt_disable(); 1578 1585 read_unlock(&tasklist_lock); 1586 + preempt_enable_no_resched(); 1579 1587 schedule(); 1580 1588 } else { 1581 1589 /*