Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

dt-bindings: serial: samsung: add specific compatibles for existing SoC

Samsung Exynos SoC reuses several devices from older designs, thus
historically we kept the old (block's) compatible only. This works fine
and there is no bug here, however guidelines expressed in
Documentation/devicetree/bindings/writing-bindings.rst state that:
1. Compatibles should be specific.
2. We should add new compatibles in case of bugs or features.

Add compatibles specific to each SoC in front of all old-SoC-like
compatibles.

Re-shuffle also the entries in compatibles, so the one-compatible-enum
is the first.

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Acked-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20231108104343.24192-8-krzysztof.kozlowski@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

+11 -3
+11 -3
Documentation/devicetree/bindings/serial/samsung_uart.yaml
··· 18 18 properties: 19 19 compatible: 20 20 oneOf: 21 - - items: 22 - - const: samsung,exynosautov9-uart 23 - - const: samsung,exynos850-uart 24 21 - enum: 25 22 - apple,s5l-uart 26 23 - axis,artpec8-uart ··· 26 29 - samsung,exynos4210-uart 27 30 - samsung,exynos5433-uart 28 31 - samsung,exynos850-uart 32 + - items: 33 + - enum: 34 + - samsung,exynos7-uart 35 + - const: samsung,exynos4210-uart 36 + - items: 37 + - enum: 38 + - samsung,exynos7885-uart 39 + - const: samsung,exynos5433-uart 40 + - items: 41 + - const: samsung,exynosautov9-uart 42 + - const: samsung,exynos850-uart 29 43 30 44 reg: 31 45 maxItems: 1