tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

phy: ti: phy-omap-usb2: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230307115900.2293120-30-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Uwe Kleine-König and committed by
Vinod Koul 5566da71 db850ea9

+2 -4
+2 -4
drivers/phy/ti/phy-omap-usb2.c
··· 506 506 return 0; 507 507 } 508 508 509 - static int omap_usb2_remove(struct platform_device *pdev) 509 + static void omap_usb2_remove(struct platform_device *pdev) 510 510 { 511 511 struct omap_usb *phy = platform_get_drvdata(pdev); 512 512 513 513 usb_remove_phy(&phy->phy); 514 514 pm_runtime_disable(phy->dev); 515 - 516 - return 0; 517 515 } 518 516 519 517 static struct platform_driver omap_usb2_driver = { 520 518 .probe = omap_usb2_probe, 521 - .remove = omap_usb2_remove, 519 + .remove_new = omap_usb2_remove, 522 520 .driver = { 523 521 .name = "omap-usb2", 524 522 .of_match_table = omap_usb2_id_table,