tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ASoC: SDCA: Update text of FIXME

A couple of attempts to correct this FIXME have been sent upstream but
the situation is not quite a simple as the FIXME implies. Update the
FIXME to include a better description of the situation.

Link: https://lore.kernel.org/linux-sound/20260408085607.3813488-1-shumingf@realtek.com/
Link: https://lore.kernel.org/linux-sound/20260324-sdca-function-status-init-irq-v1-1-bba49417a4e0@gmail.com/
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://patch.msgid.link/20260410104500.163337-1-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Charles Keepax and committed by
Mark Brown 558f5228 72dcd849

+11 -1
+11 -1
sound/soc/sdca/sdca_interrupts.c
··· 119 119 for_each_set_bit(mask, &status, BITS_PER_BYTE) { 120 120 switch (BIT(mask)) { 121 121 case SDCA_CTL_ENTITY_0_FUNCTION_NEEDS_INITIALIZATION: 122 - //FIXME: Add init writes 122 + /* 123 + * FIXME: Should this do init writes? 124 + * 125 + * Currently init writes/cache sync are done from the suspend/resume 126 + * infrastructure. It is unclear in what situations one would receive this 127 + * IRQ outside of that flow. Presumably it would be something like the chip 128 + * crashing. In that case however doing the init writes and a cache sync might 129 + * not be sufficient, for example if the failure was during audio playback 130 + * there could be ordering constraints on the register writes to restore the 131 + * state that are not handled by a simple cache sync. 132 + */ 123 133 break; 124 134 case SDCA_CTL_ENTITY_0_FUNCTION_FAULT: 125 135 dev_err(dev, "function fault\n");