Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

gtp: disable BH before calling udp_tunnel_xmit_skb()

gtp_genl_send_echo_req() runs as a generic netlink doit handler in
process context with BH not disabled. It calls udp_tunnel_xmit_skb(),
which eventually invokes iptunnel_xmit() — that uses __this_cpu_inc/dec
on softnet_data.xmit.recursion to track the tunnel xmit recursion level.

Without local_bh_disable(), the task may migrate between
dev_xmit_recursion_inc() and dev_xmit_recursion_dec(), breaking the
per-CPU counter pairing. The result is stale or negative recursion
levels that can later produce false-positive
SKB_DROP_REASON_RECURSION_LIMIT drops on either CPU.

The other udp_tunnel_xmit_skb() call sites in gtp.c are unaffected:
the data path runs under ndo_start_xmit and the echo response handlers
run from the UDP encap rx softirq, both with BH already disabled.

Fix it by disabling BH around the udp_tunnel_xmit_skb() call, mirroring
commit 2cd7e6971fc2 ("sctp: disable BH before calling
udp_tunnel_xmit_skb()").

Fixes: 6f1a9140ecda ("net: add xmit recursion limit to tunnel xmit functions")
Cc: stable@vger.kernel.org
Signed-off-by: David Carlier <devnexen@gmail.com>
Link: https://patch.msgid.link/20260417055408.4667-1-devnexen@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

David Carlier and committed by
Jakub Kicinski
5638504a f6315295

+2
+2
drivers/net/gtp.c
··· 2400 2400 return -ENODEV; 2401 2401 } 2402 2402 2403 + local_bh_disable(); 2403 2404 udp_tunnel_xmit_skb(rt, sk, skb_to_send, 2404 2405 fl4.saddr, fl4.daddr, 2405 2406 inet_dscp_to_dsfield(fl4.flowi4_dscp), ··· 2410 2409 !net_eq(sock_net(sk), 2411 2410 dev_net(gtp->dev)), 2412 2411 false, 0); 2412 + local_bh_enable(); 2413 2413 return 0; 2414 2414 } 2415 2415