tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

scripts/gdb: correct indentation in get_current_task

Patch series "scripts/gdb: Support getting current task struct in UML",
v3.

A running x86 UML kernel reports with architecture "i386:x86-64" as it is
a sub-architecture. However, a difference with bare-metal x86 kernels is
in how it manages tasks and the current task struct. To identify that the
inferior is a UML kernel and not bare-metal, check for the existence of
the UML specific symbol "cpu_tasks" which contains the current task
struct.


This patch (of 3):

There is an extra space in a couple blocks in get_current_task. Though
python does not care, let's make the spacing consistent. Also, format
better an if expression, removing unneeded parenthesis.

Link: https://lkml.kernel.org/r/cover.1677469905.git.development@efficientek.com
Link: https://lkml.kernel.org/r/2e117b82240de6893f27cb6507242ce455ed7b5b.1677469905.git.development@efficientek.com
Signed-off-by: Glenn Washburn <development@efficientek.com>
Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anton Ivanov <anton.ivanov@kot-begemot.co.uk>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: Kieran Bingham <kbingham@kernel.org>
Cc: Richard Weinberger <richard@nod.at>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

Glenn Washburn and committed by
Andrew Morton 56fe4870 3ac39d20

+9 -9
+9 -9
scripts/gdb/linux/cpus.py
··· 163 163 task_ptr_type = task_type.get_type().pointer() 164 164 165 165 if utils.is_target_arch("x86"): 166 - var_ptr = gdb.parse_and_eval("&pcpu_hot.current_task") 167 - return per_cpu(var_ptr, cpu).dereference() 166 + var_ptr = gdb.parse_and_eval("&pcpu_hot.current_task") 167 + return per_cpu(var_ptr, cpu).dereference() 168 168 elif utils.is_target_arch("aarch64"): 169 - current_task_addr = gdb.parse_and_eval("$SP_EL0") 170 - if((current_task_addr >> 63) != 0): 171 - current_task = current_task_addr.cast(task_ptr_type) 172 - return current_task.dereference() 173 - else: 174 - raise gdb.GdbError("Sorry, obtaining the current task is not allowed " 175 - "while running in userspace(EL0)") 169 + current_task_addr = gdb.parse_and_eval("$SP_EL0") 170 + if (current_task_addr >> 63) != 0: 171 + current_task = current_task_addr.cast(task_ptr_type) 172 + return current_task.dereference() 173 + else: 174 + raise gdb.GdbError("Sorry, obtaining the current task is not allowed " 175 + "while running in userspace(EL0)") 176 176 else: 177 177 raise gdb.GdbError("Sorry, obtaining the current task is not yet " 178 178 "supported with this arch")