tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

kconfig: qconf: avoid unnecessary parentSelected() when ESC is pressed

When the ESC key is pressed, the parentSelected() signal is currently
emitted for singleMode, menuMode, and symbolMode.

However, parentSelected() signal is functional only for singleMode.

In menuMode, the signal is connected to the goBack() slot, but nothing
occurs because configList->rootEntry is always &rootmenu.

In symbolMode (in the right pane), the parentSelected() signal is not
connected to any slot.

This commit prevents the unnecessary emission of the parentSelected()
signal.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Masahiro Yamada 572cd1d2 511ff539

+1 -1
+1 -1
scripts/kconfig/qconf.cc
··· 724 724 struct menu *menu; 725 725 enum prop_type type; 726 726 727 - if (ev->key() == Qt::Key_Escape && mode != fullMode && mode != listMode) { 727 + if (ev->key() == Qt::Key_Escape && mode == singleMode) { 728 728 emit parentSelected(); 729 729 ev->accept(); 730 730 return;