tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

nfc: nxp-nci: remove interrupt trigger type

For NXP NCI devices (e.g. PN7150), the interrupt is level-triggered and
active high, not edge-triggered.

Using IRQF_TRIGGER_RISING in the driver can cause interrupts to fail
to trigger correctly.

Remove IRQF_TRIGGER_RISING and rely on the IRQ trigger type configured
via Device Tree.

Signed-off-by: Carl Lee <carl.lee@amd.com>
Link: https://patch.msgid.link/20260205-fc-nxp-nci-remove-interrupt-trigger-type-v2-1-79d2ed4a7e42@amd.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Carl Lee and committed by
Jakub Kicinski 57be33f8 1fdad81d

+1 -1
+1 -1
drivers/nfc/nxp-nci/i2c.c
··· 305 305 306 306 r = request_threaded_irq(client->irq, NULL, 307 307 nxp_nci_i2c_irq_thread_fn, 308 - IRQF_TRIGGER_RISING | IRQF_ONESHOT, 308 + IRQF_ONESHOT, 309 309 NXP_NCI_I2C_DRIVER_NAME, phy); 310 310 if (r < 0) 311 311 nfc_err(&client->dev, "Unable to register IRQ handler\n");