Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ASoC: rt5682: Use a maple tree based register cache

regmap has introduced a maple tree based register cache which makes use of
this more advanced data structure which has been added to the kernel
recently. Maple trees are much flatter than rbtrees, meaning that they do
not grow to such depths when the register map is sparse which makes access
a bit more efficient. The maple tree cache type is still a bit of a work
in progress but should be effective for some devices already.

RT5682 seems like a good candidate for maple tree. It only supports single
register read/write operations so will gain minimal benefit from storing
the register data in device native format like rbtree does (none for
SoundWire) and has some sparsity in the register map which is a good fit
for maple tree.

Convert to use maple tree. There should be little if any visible difference
at runtime.

Signed-off-by: Mark Brown <broonie@kernel.org
Link: https://lore.kernel.org/r/20230419-asoc-rt5682-maple-v1-1-ed40369c9099@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org

+2 -2
+1 -1
sound/soc/codecs/rt5682-sdw.c
··· 79 79 .max_register = RT5682_I2C_MODE, 80 80 .volatile_reg = rt5682_volatile_register, 81 81 .readable_reg = rt5682_readable_register, 82 - .cache_type = REGCACHE_RBTREE, 82 + .cache_type = REGCACHE_MAPLE, 83 83 .reg_defaults = rt5682_reg, 84 84 .num_reg_defaults = RT5682_REG_NUM, 85 85 .use_single_read = true,
+1 -1
sound/soc/codecs/rt5682s.c
··· 3046 3046 .max_register = RT5682S_MAX_REG, 3047 3047 .volatile_reg = rt5682s_volatile_register, 3048 3048 .readable_reg = rt5682s_readable_register, 3049 - .cache_type = REGCACHE_RBTREE, 3049 + .cache_type = REGCACHE_MAPLE, 3050 3050 .reg_defaults = rt5682s_reg, 3051 3051 .num_reg_defaults = ARRAY_SIZE(rt5682s_reg), 3052 3052 .use_single_read = true,