tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

selftests: ublk: fix fio arguments in run_io_and_recover()

run_io_and_recover() invokes fio with --size="${size}", but the variable
size doesn't exist. Thus, the argument expands to --size=, which causes
fio to exit immediately with an error without issuing any I/O. Pass the
value for size as the first argument to the function.

Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

authored by

Caleb Sander Mateos and committed by
Jens Axboe 58eec4f3 fe8c0182

+6 -5
+3 -2
tools/testing/selftests/ublk/test_common.sh
··· 333 333 334 334 run_io_and_recover() 335 335 { 336 - local action=$1 336 + local size=$1 337 + local action=$2 337 338 local state 338 339 local dev_id 339 340 340 - shift 1 341 + shift 2 341 342 dev_id=$(_add_ublk_dev "$@") 342 343 _check_add_dev "$TID" $? 343 344
+1 -1
tools/testing/selftests/ublk/test_generic_04.sh
··· 8 8 9 9 ublk_run_recover_test() 10 10 { 11 - run_io_and_recover "kill_daemon" "$@" 11 + run_io_and_recover 256M "kill_daemon" "$@" 12 12 ERR_CODE=$? 13 13 if [ ${ERR_CODE} -ne 0 ]; then 14 14 echo "$TID failure: $*"
+1 -1
tools/testing/selftests/ublk/test_generic_05.sh
··· 8 8 9 9 ublk_run_recover_test() 10 10 { 11 - run_io_and_recover "kill_daemon" "$@" 11 + run_io_and_recover 256M "kill_daemon" "$@" 12 12 ERR_CODE=$? 13 13 if [ ${ERR_CODE} -ne 0 ]; then 14 14 echo "$TID failure: $*"
+1 -1
tools/testing/selftests/ublk/test_generic_11.sh
··· 8 8 9 9 ublk_run_quiesce_recover() 10 10 { 11 - run_io_and_recover "quiesce_dev" "$@" 11 + run_io_and_recover 256M "quiesce_dev" "$@" 12 12 ERR_CODE=$? 13 13 if [ ${ERR_CODE} -ne 0 ]; then 14 14 echo "$TID failure: $*"