Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
sctp: make sctp_transport_init() void
sctp_transport_init() is static and never returns NULL. It is only
called by sctp_transport_new(), so change it to void and remove the
redundant return value check.
Signed-off-by: Huiwen He <hehuiwen@kylinos.cn>
Acked-by: Xin Long <lucien.xin@gmail.com>
Link: https://patch.msgid.link/20251103023619.1025622-1-hehuiwen@kylinos.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
authored by
Huiwen He
and committed by
Jakub Kicinski
59b20b15
5556f234
+6
-15
+6
-15
net/sctp/transport.c
+6
-15
net/sctp/transport.c
···
37
37
/* 1st Level Abstractions. */
38
38
39
39
/* Initialize a new transport from provided memory. */
40
-
static struct sctp_transport *sctp_transport_init(struct net *net,
41
-
struct sctp_transport *peer,
42
-
const union sctp_addr *addr,
43
-
gfp_t gfp)
40
+
static void sctp_transport_init(struct net *net,
41
+
struct sctp_transport *peer,
42
+
const union sctp_addr *addr,
43
+
gfp_t gfp)
44
44
{
45
45
/* Copy in the address. */
46
46
peer->af_specific = sctp_get_af_specific(addr->sa.sa_family);
···
83
83
get_random_bytes(&peer->hb_nonce, sizeof(peer->hb_nonce));
84
84
85
85
refcount_set(&peer->refcnt, 1);
86
-
87
-
return peer;
88
86
}
89
87
90
88
/* Allocate and initialize a new transport. */
···
94
96
95
97
transport = kzalloc(sizeof(*transport), gfp);
96
98
if (!transport)
97
-
goto fail;
99
+
return NULL;
98
100
99
-
if (!sctp_transport_init(net, transport, addr, gfp))
100
-
goto fail_init;
101
+
sctp_transport_init(net, transport, addr, gfp);
101
102
102
103
SCTP_DBG_OBJCNT_INC(transport);
103
104
104
105
return transport;
105
-
106
-
fail_init:
107
-
kfree(transport);
108
-
109
-
fail:
110
-
return NULL;
111
106
}
112
107
113
108
/* This transport is no longer needed. Free up if possible, or