Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

dt-bindings: mmc: samsung,exynos-dw-mshc: add specific compatibles for existing SoC

Samsung Exynos SoC reuses several devices from older designs, thus
historically we kept the old (block's) compatible only. This works fine
and there is no bug here, however guidelines expressed in
Documentation/devicetree/bindings/writing-bindings.rst state that:
1. Compatibles should be specific.
2. We should add new compatibles in case of bugs or features.

Add compatibles specific to each SoC in front of all old-SoC-like
compatibles.

While re-indenting the first enum, put also axis,artpec8-dw-mshc in
alphabetical order.

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
Link: https://lore.kernel.org/r/20231108104343.24192-5-krzysztof.kozlowski@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

+16 -9
+16 -9
Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml
··· 14 14 15 15 properties: 16 16 compatible: 17 - enum: 18 - - samsung,exynos4210-dw-mshc 19 - - samsung,exynos4412-dw-mshc 20 - - samsung,exynos5250-dw-mshc 21 - - samsung,exynos5420-dw-mshc 22 - - samsung,exynos5420-dw-mshc-smu 23 - - samsung,exynos7-dw-mshc 24 - - samsung,exynos7-dw-mshc-smu 25 - - axis,artpec8-dw-mshc 17 + oneOf: 18 + - enum: 19 + - axis,artpec8-dw-mshc 20 + - samsung,exynos4210-dw-mshc 21 + - samsung,exynos4412-dw-mshc 22 + - samsung,exynos5250-dw-mshc 23 + - samsung,exynos5420-dw-mshc 24 + - samsung,exynos5420-dw-mshc-smu 25 + - samsung,exynos7-dw-mshc 26 + - samsung,exynos7-dw-mshc-smu 27 + - items: 28 + - enum: 29 + - samsung,exynos5433-dw-mshc-smu 30 + - samsung,exynos7885-dw-mshc-smu 31 + - samsung,exynos850-dw-mshc-smu 32 + - const: samsung,exynos7-dw-mshc-smu 26 33 27 34 reg: 28 35 maxItems: 1