tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/meson: fix 1px pink line on GXM when scaling video overlay

Playing media with a resolution smaller than the crtc size requires the
video overlay to be scaled for output and GXM boards display a 1px pink
line on the bottom of the scaled overlay. Comparing with the downstream
vendor driver revealed VPP_DUMMY_DATA not being set [0].

Setting VPP_DUMMY_DATA prevents the 1px pink line from being seen.

[0] https://github.com/endlessm/linux-s905x/blob/master/drivers/amlogic/amports/video.c#L7869

Fixes: bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller")
Suggested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230303123312.155164-1-christianshewitt@gmail.com

authored by

Christian Hewitt and committed by
Neil Armstrong 5c8cf166 4d8457fe

+2
+2
drivers/gpu/drm/meson/meson_vpp.c
··· 100 100 priv->io_base + _REG(VPP_DOLBY_CTRL)); 101 101 writel_relaxed(0x1020080, 102 102 priv->io_base + _REG(VPP_DUMMY_DATA1)); 103 + writel_relaxed(0x42020, 104 + priv->io_base + _REG(VPP_DUMMY_DATA)); 103 105 } else if (meson_vpu_is_compatible(priv, VPU_COMPATIBLE_G12A)) 104 106 writel_relaxed(0xf, priv->io_base + _REG(DOLBY_PATH_CTRL)); 105 107