tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mux: mmio: drop obsolete dependency on COMPILE_TEST

Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.

It is actually better to always build such drivers with OF enabled,
so that the test builds are closer to how each driver will actually be
built on its intended target. Building them without OF may not test
much as the compiler will optimize out potentially large parts of the
code. In the worst case, this could even pop false positive warnings.
Dropping COMPILE_TEST here improves the quality of our testing and
avoids wasting time on non-existent issues.

As a minor optimization, this also lets us drop of_match_ptr(), as we
now know what it will resolve to, we might as well save cpp some work.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Peter Rosin <peda@axentia.se>
Link: https://lore.kernel.org/r/bc790b4e-1cb4-4ef5-3da8-9d0e6b613bc7@axentia.se
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Jean Delvare and committed by
Greg Kroah-Hartman 5ccf4028 b866e7e7

+2 -2
+1 -1
drivers/mux/Kconfig
··· 47 47 48 48 config MUX_MMIO 49 49 tristate "MMIO/Regmap register bitfield-controlled Multiplexer" 50 - depends on OF || COMPILE_TEST 50 + depends on OF 51 51 help 52 52 MMIO/Regmap register bitfield-controlled Multiplexer controller. 53 53
+1 -1
drivers/mux/mmio.c
··· 131 131 static struct platform_driver mux_mmio_driver = { 132 132 .driver = { 133 133 .name = "mmio-mux", 134 - .of_match_table = of_match_ptr(mux_mmio_dt_ids), 134 + .of_match_table = mux_mmio_dt_ids, 135 135 }, 136 136 .probe = mux_mmio_probe, 137 137 };