Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

block: improve blk_op_str() comment

Replace XXX with what it actually means.

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

authored by

Damien Le Moal and committed by
Jens Axboe
5e35a24c 41ee77b7

+6 -6
+5 -5
block/blk-core.c
··· 114 114 #undef REQ_OP_NAME 115 115 116 116 /** 117 - * blk_op_str - Return string XXX in the REQ_OP_XXX. 118 - * @op: REQ_OP_XXX. 117 + * blk_op_str - Return the string "name" for an operation REQ_OP_name. 118 + * @op: a request operation. 119 119 * 120 - * Description: Centralize block layer function to convert REQ_OP_XXX into 121 - * string format. Useful in the debugging and tracing bio or request. For 122 - * invalid REQ_OP_XXX it returns string "UNKNOWN". 120 + * Convert a request operation REQ_OP_name into the string "name". Useful for 121 + * debugging and tracing BIOs and requests. For an invalid request operation 122 + * code, the string "UNKNOWN" is returned. 123 123 */ 124 124 inline const char *blk_op_str(enum req_op op) 125 125 {
+1 -1
include/linux/blkdev.h
··· 1026 1026 extern void blk_queue_exit(struct request_queue *q); 1027 1027 extern void blk_sync_queue(struct request_queue *q); 1028 1028 1029 - /* Helper to convert REQ_OP_XXX to its string format XXX */ 1029 + /* Convert a request operation REQ_OP_name into the string "name" */ 1030 1030 extern const char *blk_op_str(enum req_op op); 1031 1031 1032 1032 int blk_status_to_errno(blk_status_t status);