Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
pinctrl: realtek: Simplify error handling with dev_err_probe()
Convert the error handling code in probe() to use dev_err_probe() to
enhance semantic meaning.
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com>
Signed-off-by: Linus Walleij <linusw@kernel.org>
authored by
Yu-Chun Lin
and committed by
Linus Walleij
5e783510
b7f698b2
+5
-6
+5
-6
drivers/pinctrl/realtek/pinctrl-rtd.c
+5
-6
drivers/pinctrl/realtek/pinctrl-rtd.c
···
566
566
data->regmap_pinctrl = devm_regmap_init_mmio(data->dev, data->base,
567
567
&rtd_pinctrl_regmap_config);
568
568
569
-
if (IS_ERR(data->regmap_pinctrl)) {
570
-
dev_err(data->dev, "failed to init regmap: %ld\n",
571
-
PTR_ERR(data->regmap_pinctrl));
572
-
return PTR_ERR(data->regmap_pinctrl);
573
-
}
569
+
if (IS_ERR(data->regmap_pinctrl))
570
+
return dev_err_probe(data->dev, PTR_ERR(data->regmap_pinctrl),
571
+
"Failed to init regmap\n");
574
572
575
573
data->pcdev = devm_pinctrl_register(&pdev->dev, &data->desc, data);
576
574
if (IS_ERR(data->pcdev))
577
-
return PTR_ERR(data->pcdev);
575
+
return dev_err_probe(data->dev, PTR_ERR(data->pcdev),
576
+
"Failed to register pinctrl\n");
578
577
579
578
platform_set_drvdata(pdev, data);
580
579