tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ALSA: hda/tas2781: do not call pm_runtime_force_* in system_resume/suspend

The runtime_resume function calls prmg_load and apply_calibration
functions, but system_resume also calls them, so calling
pm_runtime_force_resume before reset is unnecessary.

For consistency, do not call the pm_runtime_force_suspend in
system_suspend, as runtime_suspend does the same.

Fixes: 5be27f1e3ec9 ("ALSA: hda/tas2781: Add tas2781 HDA driver")
Signed-off-by: Gergo Koteles <soyer@irl.hu>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Message-ID: <d0b4cc1248b9d375d59c009563da42d60d69eac3.1709918447.git.soyer@irl.hu>

authored by

Gergo Koteles and committed by
Takashi Iwai 5f51de7e bec7760a

+1 -10
+1 -10
sound/pci/hda/tas2781_hda_i2c.c
··· 870 870 static int tas2781_system_suspend(struct device *dev) 871 871 { 872 872 struct tas2781_hda *tas_hda = dev_get_drvdata(dev); 873 - int ret; 874 873 875 874 dev_dbg(tas_hda->priv->dev, "System Suspend\n"); 876 - 877 - ret = pm_runtime_force_suspend(dev); 878 - if (ret) 879 - return ret; 880 875 881 876 mutex_lock(&tas_hda->priv->codec_lock); 882 877 ··· 890 895 static int tas2781_system_resume(struct device *dev) 891 896 { 892 897 struct tas2781_hda *tas_hda = dev_get_drvdata(dev); 893 - int i, ret; 898 + int i; 894 899 895 900 dev_dbg(tas_hda->priv->dev, "System Resume\n"); 896 - 897 - ret = pm_runtime_force_resume(dev); 898 - if (ret) 899 - return ret; 900 901 901 902 mutex_lock(&tas_hda->priv->codec_lock); 902 903