tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mm/early_ioremap: clean up the use of WARN() for debugging

Using WARN() for debugging is strange when nothing is wrong, so replace
WARN(early_ioremap_debug) with pr_warn() + dump_stack().

Link: https://lkml.kernel.org/r/d4470531ce0c03fd80f9a1be7e8d8ae1bc60fcd1.1768220636.git.houwenlong.hwl@antgroup.com
Signed-off-by: Hou Wenlong <houwenlong.hwl@antgroup.com>
Suggested-by: Mike Rapoport <rppt@kernel.org>
Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Cc: David Hildenbrand <david@kernel.org>
Cc: Hou Wenlong <houwenlong.hwl@antgroup.com>
Cc: Liam Howlett <liam.howlett@oracle.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

Hou Wenlong and committed by
Andrew Morton 5fd8391c 0cc3197b

+11 -4
+11 -4
mm/early_ioremap.c
··· 30 30 } 31 31 early_param("early_ioremap_debug", early_ioremap_debug_setup); 32 32 33 + #define early_ioremap_dbg(fmt, args...) \ 34 + do { \ 35 + if (unlikely(early_ioremap_debug)) { \ 36 + pr_warn(fmt, ##args); \ 37 + dump_stack(); \ 38 + } \ 39 + } while (0) 40 + 33 41 static int after_paging_init __initdata; 34 42 35 43 pgprot_t __init __weak early_memremap_pgprot_adjust(resource_size_t phys_addr, ··· 147 139 if (WARN_ON(nrpages > NR_FIX_BTMAPS)) 148 140 return NULL; 149 141 150 - WARN(early_ioremap_debug, "%s(%pa, %08lx) [%d] => %08lx + %08lx\n", 151 - __func__, &phys_addr, size, slot, slot_virt[slot], offset); 142 + early_ioremap_dbg("%s(%pa, %08lx) [%d] => %08lx + %08lx\n", 143 + __func__, &phys_addr, size, slot, slot_virt[slot], offset); 152 144 153 145 /* 154 146 * Ok, go for it.. ··· 193 185 __func__, addr, size, slot, prev_size[slot])) 194 186 return; 195 187 196 - WARN(early_ioremap_debug, "%s(%p, %08lx) [%d]\n", 197 - __func__, addr, size, slot); 188 + early_ioremap_dbg("%s(%p, %08lx) [%d]\n", __func__, addr, size, slot); 198 189 199 190 virt_addr = (unsigned long)addr; 200 191 if (WARN_ON(virt_addr < fix_to_virt(FIX_BTMAP_BEGIN)))