Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
Input: sx8654 - use IRQF_NOAUTOEN when requesting interrupt
Instead of requesting interrupt normally and immediately disabling it
with call to disable_irq() use IRQF_NOAUTOEN to keep it disabled until
it is needed. This avoids a tiny window when interrupt is enabled but
not needed.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
+5
-4
+5
-4
drivers/input/touchscreen/sx8654.c
+5
-4
drivers/input/touchscreen/sx8654.c
···
391
391
return error;
392
392
}
393
393
394
+
/*
395
+
* Start with the interrupt disabled, it will be enabled in
396
+
* sx8654_open().
397
+
*/
394
398
error = devm_request_threaded_irq(&client->dev, client->irq,
395
399
NULL, sx8654->data->irqh,
396
-
IRQF_ONESHOT,
400
+
IRQF_ONESHOT | IRQF_NO_AUTOEN,
397
401
client->name, sx8654);
398
402
if (error) {
399
403
dev_err(&client->dev,
···
405
401
client->irq, error);
406
402
return error;
407
403
}
408
-
409
-
/* Disable the IRQ, we'll enable it in sx8654_open() */
410
-
disable_irq(client->irq);
411
404
412
405
error = input_register_device(sx8654->input);
413
406
if (error)